Merge pull request #1525 from /issues/1204/1

Fixes #1204. Fix disapppearing label editor icon.

Author: karlcow

webcompat/static/js/lib/issues.js

@@ -344,13 +344,6 @@ issues.StateButtonView = Backbone.View.extend({
         this.render();
       }, this)
     );
-
-    this.model.on(
-      "change:labels",
-      _.bind(function() {
-        this.mainView.labels.renderLabels();
-      }, this)
-    );
   },
   template: _.template($("#state-button-tmpl").html()),
   render: function() {

webcompat/static/js/lib/labels.js

@@ -41,7 +41,7 @@ issues.LabelsView = Backbone.View.extend({
   subTemplate: _.template(
     [
       "<% _.each(labels, function(label) { %>",
-      '<span class="wc-Label wc-Label--badge" style="background-color:#<%=label.color%>">',
+      '<span class="wc-Label wc-Label--badge js-Label" style="background-color:#<%=label.color%>">',
       "<%= label.name %>",
       "</span>",
       "<% }); %>"
@@ -114,7 +114,7 @@ issues.LabelEditorView = Backbone.View.extend({
   reRender: function(data) {
     //only re-render the labels into the labels wrapper
     this.issueView.$el
-      .find(".js-label-list")
+      .find(".js-Label-list")
       .html(this.issueView.subTemplate(data));
     this.issueView.$el.find(".js-LabelEditorLauncher").addClass("is-active");
   },
@@ -176,7 +176,7 @@ issues.LabelEditorView = Backbone.View.extend({
       item.color = $(item).data("color");
       modelUpdate.push(item);
     });
-    this.reRender({ labels: modelUpdate });
+    this.reRender({ labels: _.uniq(modelUpdate) });
   },
   closeEditor: function() {
     var checked = $("input[type=checkbox]:checked");

webcompat/static/js/lib/models/label-list.js

@@ -36,7 +36,6 @@ issues.LabelList = Backbone.Model.extend({
     });
     // if we're initialized with {labels:array-of-objects}, process the data
     var inputLabelData = this.get("labels");
-    this.set("labels", []);
     if (inputLabelData) {
       this.parse(inputLabelData);
     } else {