Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labels gear disappears after changing labels #1204

Closed
karlcow opened this issue Oct 17, 2016 · 4 comments
Closed

labels gear disappears after changing labels #1204

karlcow opened this issue Oct 17, 2016 · 4 comments
Assignees
@miketaylr
Labels
lang: JS type: bug
Milestone
Labels Work

Comments

@karlcow
Copy link
Member

karlcow commented Oct 17, 2016

  1. Write a comment and change the status of the bug.
  2. Submit

The gear disappears.
The page needs to be reloaded to make the gear visible again.
@miketaylr miketaylr self-assigned this Dec 13, 2016
@miketaylr
Copy link
Member

Confirmed. I think I have an idea.

@miketaylr
Copy link
Member

I don't think comments matter here, just changing a label is sufficient to make the label gear disappear.

@miketaylr miketaylr changed the title labels gear disappears after submitting comment labels gear disappears after changing labels Dec 31, 2016
@miketaylr
Copy link
Member

Also, we end up calling the on('change:labels' handler inside LabelList model 5 times whenever we change a label. O_o

change:labels inside LabelList model label-list.js:35:7 x 2
change:labels inside LabelList model label-list.js:35:7 x 3

@karlcow karlcow mentioned this issue Jan 12, 2017
Closed
@karlcow karlcow added this to the Labels Work milestone Mar 3, 2017
@miketaylr miketaylr mentioned this issue Apr 21, 2017
Closed
@karlcow karlcow mentioned this issue Apr 21, 2017
Open
@miketaylr
Copy link
Member

Also, we end up calling the on('change:labels' handler inside LabelList model 5 times whenever we change a label. O_o

If that was true in the past, it's not now. We call it once in the issue model handler, and once in the StateButtonView, which is expected.

miketaylr pushed a commit that referenced this issue Apr 24, 2017
Issue #1204. Remove extra (unneeded) call to render labels.
2dbea4e 
This was happening when an issue was close/opened, but the issue status view
shouldn't be worrying about labels.
miketaylr pushed a commit that referenced this issue Apr 24, 2017
Issue #1204. Add missing class in subTemplate and fix selector typo.
a5d6005
miketaylr pushed a commit that referenced this issue Apr 24, 2017
Issue #1204. Make sure to re-render with a unique list.
0ed6d2c 
(GitHub only returns a unique list, but it's possible for the list
to be non-unique client-side, which can result in jumpy renders.
miketaylr pushed a commit that referenced this issue Apr 24, 2017
Issue #1204. Remove useless prop set (which sends out change events).
578334c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
lang: JS type: bug
Projects
None yet
Milestone
Labels Work
Development

No branches or pull requests
3 participants
@miketaylr @karlcow @magsout