-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
[build][misc] allow to use recent numpy #12759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
I think we also need to update the compiled |
I think you need to pip compile with |
hi @DarkLight1337 -yuan |
@debermudez @jikunshang could you help us understand if genai-perf can update to recent numpy? |
@mgoin this actually came up today in a different thread for our team. I think another team mate is already working on it. |
Yes, here's the feedback from genai-perf dev |
Done, thanks for raising this! triton-inference-server/perf_analyzer#275 |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Yuan Zhou <[email protected]>
|
@rgommers Yes, |
This pull request has merge conflicts that must be resolved before it can be |
Resolved by another PR |
Hi @mgoin it looks like Thanks, -yuan |
That is for testing, which has many more deps than the package itself have. There is no restriction on the common numpy version anymore https://github.com/vllm-project/vllm/blob/main/requirements/common.txt |
This patch removed the limitation on
numpy < 2.0.0
outlines already did a workaround for running with recent numpy
dottxt-ai/outlines#1265
Fixes #6570