Skip to content

[build][misc] allow to use recent numpy #12759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zhouyuan
Copy link
Contributor

@zhouyuan zhouyuan commented Feb 5, 2025

This patch removed the limitation on numpy < 2.0.0
outlines already did a workaround for running with recent numpy
dottxt-ai/outlines#1265

Fixes #6570

Copy link

github-actions bot commented Feb 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 5, 2025
@jeejeelee jeejeelee requested a review from youkaichao February 5, 2025 03:38
@DarkLight1337
Copy link
Member

I think we also need to update the compiled requirements-test.txt?

@DarkLight1337
Copy link
Member

I think you need to pip compile with -P numpy to keep the numpy version in the output txt

@zhouyuan
Copy link
Contributor Author

zhouyuan commented Feb 5, 2025

I think you need to pip compile with -P numpy to keep the numpy version in the output txt

hi @DarkLight1337
it seems genai-perf has a requirement for old numpy, so pip compile will stick to 1.26.4
https://github.com/triton-inference-server/perf_analyzer/blob/main/genai-perf/pyproject.toml#L51
The genai-perf is only used in nightly benchmarks, but it's marked as one dependency in test. So I think we should try to bump the numpy in genai-perf package firstly?

-yuan

@DarkLight1337
Copy link
Member

cc @robertgshaw2-redhat

@mgoin
Copy link
Member

mgoin commented Feb 5, 2025

@debermudez @jikunshang could you help us understand if genai-perf can update to recent numpy?

@debermudez
Copy link

@mgoin this actually came up today in a different thread for our team. I think another team mate is already working on it.

@zhouyuan
Copy link
Contributor Author

zhouyuan commented Feb 5, 2025

Yes, here's the feedback from genai-perf dev
triton-inference-server/perf_analyzer#272 (comment)

@dyastremsky
Copy link

Done, thanks for raising this! triton-inference-server/perf_analyzer#275

Copy link

mergify bot commented Mar 6, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @zhouyuan.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 6, 2025
@rgommers
Copy link

rgommers commented Mar 9, 2025

genai-perf 0.0.11 was released with numpy 2 support five days ago, so this PR should be unblocked. Could you please rebase @zhouyuan? It'd be great to get this in.

@zhouyuan
Copy link
Contributor Author

genai-perf 0.0.11 was released with numpy 2 support five days ago, so this PR should be unblocked. Could you please rebase @zhouyuan? It'd be great to get this in.

@rgommers Yes, genai-perf is fine now, there seems to have legacy code in tritonclient which still have this restriction. I have made a quick patch here:

triton-inference-server/client#826

Copy link

mergify bot commented May 6, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @zhouyuan.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 6, 2025
@mgoin
Copy link
Member

mgoin commented May 6, 2025

Resolved by another PR

@mgoin mgoin closed this May 6, 2025
@zhouyuan
Copy link
Contributor Author

zhouyuan commented May 6, 2025

Hi @mgoin it looks like numpy==1.26.4 is still a requirement here. Not sure if I was looking at the wrong place.
https://github.com/vllm-project/vllm/blob/main/requirements/test.txt#L318

Thanks, -yuan

@mgoin
Copy link
Member

mgoin commented May 6, 2025

That is for testing, which has many more deps than the package itself have. There is no restriction on the common numpy version anymore https://github.com/vllm-project/vllm/blob/main/requirements/common.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to numpy >= 2.0.0
6 participants