Skip to content

Support Numpy 2 #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Support Numpy 2 #275

merged 1 commit into from
Feb 6, 2025

Conversation

dyastremsky
Copy link
Contributor

No description provided.

@dyastremsky
Copy link
Contributor Author

Thanks for approving so quickly! CI is running.

@nv-hwoo
Copy link
Contributor

nv-hwoo commented Feb 5, 2025

Just to double check: I think we were restricting the numpy version to 1.x due to some breaking changes in 2.0 API (triton-inference-server/client#690) but that was mainly affecting triton python client and not genai-perf, correct?

@debermudez
Copy link
Contributor

Just to double check: I think we were restricting the numpy version to 1.x due to some breaking changes in 2.0 API (triton-inference-server/client#690) but that was mainly affecting triton python client and not genai-perf, correct?

I believe we restricted it because we didnt have the bandwidth to verify the API change and no one was directly asking for it.
With the new ask from vllm and internal folks plus the additional testing around our use of the library, it is a good time to do the update.

@dyastremsky dyastremsky merged commit 834b19c into main Feb 6, 2025
6 of 7 checks passed
@dyastremsky dyastremsky deleted the dyas-numpy branch February 6, 2025 04:20
lkomali pushed a commit that referenced this pull request Feb 6, 2025
@zhouyuan
Copy link

zhouyuan commented Feb 7, 2025

@dyastremsky thank you so much for the fix. Do you happen to know if there will a new release to include this change recently?

@dyastremsky
Copy link
Contributor Author

dyastremsky commented Feb 7, 2025

@dyastremsky thank you so much for the fix. Do you happen to know if there will a new release to include this change recently?

My pleasure! I think this should make it into 25.02.

@rgommers
Copy link

I think this should make it into 25.02.

Can I ask when this is planned and where to look for releases? https://pypi.org/project/genai-perf is at 0.0.10, which doesn't give the impression that 25.02 is next.

@nv-hwoo
Copy link
Contributor

nv-hwoo commented Feb 22, 2025

@rgommers you can expect it to be part of 0.0.11 version, which should be released soon.

zhouyuan added a commit to zhouyuan/client that referenced this pull request Mar 10, 2025
genai_perf package already includes this change
triton-inference-server/perf_analyzer#275
indrajit96 pushed a commit to triton-inference-server/client that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants