Skip to content

ci: allow to use recent numpy #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

zhouyuan
Copy link
Contributor

@zhouyuan zhouyuan commented Mar 10, 2025

This patch removed the "numpy<2" restrict.

genai_perf package already includes this change
triton-inference-server/perf_analyzer#275

Cc: @dyastremsky

genai_perf package already includes this change
triton-inference-server/perf_analyzer#275
@zhouyuan
Copy link
Contributor Author

@indrajit96 could you please kindly help to take a look? Thanks.

@dyastremsky
Copy link
Contributor

dyastremsky commented Mar 14, 2025

@statiraju @krishung5 @kthui, would anyone be able to review this PR? I assume this should be fine for the client code.

Edit: Just noticed that Yuan already tagged Indrajit. This will help unblock vLLM. Anyone's review/approval here would be appreciated.

@indrajit96
Copy link
Contributor

Hi @zhouyuan, have triggered a CI for this.
Will merge on CI completion.

@indrajit96
Copy link
Contributor

CI looks good to me waiting for CI review and approval to merge

@indrajit96 indrajit96 self-requested a review March 19, 2025 21:45
Copy link
Contributor

@indrajit96 indrajit96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good to me waiting for CI review and approval to merge

@indrajit96 indrajit96 merged commit a11eb0a into triton-inference-server:main Mar 20, 2025
3 checks passed
@indrajit96
Copy link
Contributor

@zhouyuan this is merged

@zhouyuan
Copy link
Contributor Author

@indrajit96 Thank you so much for the review and merge! Would it be convenient to included this commit in the coming 25.03 release?

thanks, -yuan

@rgommers
Copy link

rgommers commented Apr 7, 2025

This PR isn't yet included in the 25.03 branch: https://github.com/triton-inference-server/client/blob/r25.03/src/python/library/requirements/requirements.txt#L27

It'd be great to include this, it should be safe and unblocks a bunch of other projects (e.g., vllm and everyone who depends on that).

@dyastremsky
Copy link
Contributor

The Triton policy is generally not to patch prior releases. This commit was merged in between commits, so it will be included in our next monthly release, 25.04.

CC: @statiraju

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants