-
Notifications
You must be signed in to change notification settings - Fork 5
feat: update ground segmentation evaluator to be compatible with lidarseg dataset #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: update ground segmentation evaluator to be compatible with lidarseg dataset #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR discontinues the annotated_rosbag
mode and reimplements annotated_pcd
to use the new lidarseg.json
spec for segmentation labels.
- Drop
annotated_rosbag
support and related synchronization code - Load separate label files via
lidarseg.json
inannotated_pcd
mode - Update
CLOUD_DIM
from 6 to 5 for the new point format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
driving_log_replayer_v2/scripts/ground_segmentation_evaluator_node.py | Remove rosbag mode, adjust annotated_pcd to parse labels from lidarseg.json , and set CLOUD_DIM=5 . |
driving_log_replayer_v2/driving_log_replayer_v2/ground_segmentation.py | Remove Method field from Condition model to match dropped rosbag mode. |
Comments suppressed due to low confidence (3)
driving_log_replayer_v2/scripts/ground_segmentation_evaluator_node.py:22
- The import ros2_numpy is no longer used after removing
annotated_rosbag_eval_cb
; consider removing this unused import.
import ros2_numpy
driving_log_replayer_v2/scripts/ground_segmentation_evaluator_node.py:53
- Unconditionally loading annotated PCD mode without validating
eval_condition.Method
may allow unsupported methods; add a check and raise an error if it's not "annotated_pcd".
sample_data_path = Path(self._t4_dataset_paths[0], "annotation", "sample_data.json")
driving_log_replayer_v2/driving_log_replayer_v2/ground_segmentation.py:27
- The
Method
field was removed from theCondition
model but the evaluator still relies on mode configuration; re-add or update the model to match expected scenario parameters.
Method: Literal["annotated_pcd", "annotated_rosbag"]
@nanoshimarobot
|
@@ -6,14 +6,6 @@ Evaluate the performance of the Obstacle Segmentation sub-component in Autoware, | |||
|
|||
The Ground Truth data required for evaluation can be provided using the following two methods, and each can be used by changing the `Evaluation.Conditions.Method` of the scenario. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ground Truth data required for evaluation can be provided using the following two methods, and each can be used by changing the `Evaluation.Conditions.Method` of the scenario. | |
The Ground Truth data required for evaluation can be provided using the following method |
Synchronize and subscribe to topics before and after ground removal, and evaluate the accuracy by comparing the number of points with ground and non-ground labels. | ||
|
||
In this evaluation framework, the semantic labels are assumed to be recorded in an `INT32` field named `entity_id`. | ||
|
||
### annotated_pcd | ||
|
||
This method involves adding a field to the point cloud data provided as a dataset (`dataset/data/LIDAR_CONCAT/\*.pcd.bin`) to represent semantic labels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This's also outdate and need to be updated
@nanoshimarobot could you also put the command you used and the evaluator testing result in description for reference? |
I updated the PR description to include the test command and a sample output. |
I also confirmed 'ground_segmentation_evaluator' works with latest lidar semantic segmentation dataset format
|
@nanoshimarobot plz fix ci(spell-check) error. |
@badai-nguyen
|
I will review it until next week, sorry for delay 🙇 |
@MasatoSaeki Could you review this PR? |
Sorry, just a minute! |
Types of PR
Description
This PR removes the
annotated_rosbag
mode from ground_segmentation_evaluator and updates theannotated_pcd
mode.Remove
annotated_rosbag
Maintaining this mode requires patching autoware.universe, which has become burdensome and error-prone. So we’re simply discontinuing this mode.
Update
annotated_pcd
Until now, segmentation labels were assumed to be written directly into
t4_dataset/data/LIDAR_CONCAT/*.pcd.bin
.Since this PR introduced a standard format and location for lidar segmentation labels,
annotated_pcd
has been re-implemented to follow that spec.TIER IV internal link
How to review this PR
Test data and scenario
test dataset : TIERIV_INTERNAL_LINK
scenario:
Test command
Test result
Note: If no evaluation results are produced, change the point cloud topic to the following:
or
Others