Skip to content

feat: delete system defined remap #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 4, 2025
Merged

feat: delete system defined remap #159

merged 5 commits into from
Jun 4, 2025

Conversation

hayato-m126
Copy link
Collaborator

Types of PR

  • New Features

Description

  • delete system_defined_remap

How to review this PR

Others

@hayato-m126
feat: delete system defined remap
e27778e 
Signed-off-by: Hayato Mizushima <[email protected]>
xtk8532704
xtk8532704 previously approved these changes Jun 3, 2025
View reviewed changes
Copy link

@xtk8532704 xtk8532704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@MasatoSaeki
Copy link
Contributor

MasatoSaeki commented Jun 3, 2025 •
edited
Loading

@hayato-m126
You would delete the relevant codes like https://github.com/tier4/driving_log_replayer_v2/blob/develop/driving_log_replayer_v2/driving_log_replayer_v2/launch/rosbag.py#L58, in other PRs, right?
Sorry, I made mistake, ignore it.

@hayato-m126
Copy link
Collaborator Author

I don't think we need to force this PR change on the other PRs that are out there now.

There is no conflict.

@hayato-m126
Copy link
Collaborator Author

Thank you for creating pilot-auto's PR.

MasatoSaeki
MasatoSaeki previously approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by https://github.com/tier4/pilot-auto/pull/1455.

xtk8532704
xtk8532704 previously approved these changes Jun 4, 2025
View reviewed changes
Copy link

@xtk8532704 xtk8532704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

TadaKazuto
TadaKazuto previously approved these changes Jun 4, 2025
View reviewed changes
SakodaShintaro
SakodaShintaro requested changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that remapping depending on the launched modules reduces flexibility.
However, rather than removing this mechanism, is it possible to remap depending on the scenario type?

@hayato-m126
Copy link
Collaborator Author

@SakodaShintaro

I understand that remapping depending on the launched modules reduces flexibility. However, rather than removing this mechanism, is it possible to remap depending on the scenario type?

By scenario type do you mean localizaton or ndt_convergence?
If so, it is possible.
Because you can get it as use_case, and you can condition it to be remapped in certain use_cases.

driving_log_replayer_v2/driving_log_replayer_v2/driving_log_replayer_v2/launch/argument.py

Line 221 in 18560cc

conf["use_case"] = yaml_obj["Evaluation"]["UseCaseName"]

@hayato-m126 hayato-m126 dismissed stale reviews from TadaKazuto, xtk8532704, and MasatoSaeki via 2e19257 June 4, 2025 08:07
@hayato-m126
fix: bug
f3c0e7e 
Signed-off-by: Hayato Mizushima <[email protected]>
@hayato-m126
Copy link
Collaborator Author

@MasatoSaeki @xtk8532704 @SakodaShintaro @TadaKazuto
I updated the code.
Please re-check this PR.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

SakodaShintaro
SakodaShintaro approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

xtk8532704
xtk8532704 approved these changes Jun 4, 2025
View reviewed changes
Copy link

@xtk8532704 xtk8532704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

MasatoSaeki
MasatoSaeki approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TadaKazuto
TadaKazuto approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@TadaKazuto TadaKazuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@hayato-m126 hayato-m126 merged commit 37ee90e into develop Jun 4, 2025
5 checks passed
@hayato-m126 hayato-m126 deleted the feat/delete-system-defined-remap branch June 4, 2025 10:07
TadaKazuto pushed a commit that referenced this pull request Jun 5, 2025
@hayato-m126 @TadaKazuto
feat: delete system defined remap (#159)
e5b49e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtk8532704 xtk8532704 xtk8532704 approved these changes

@SakodaShintaro SakodaShintaro SakodaShintaro approved these changes

@MasatoSaeki MasatoSaeki MasatoSaeki approved these changes

@TadaKazuto TadaKazuto TadaKazuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hayato-m126 @MasatoSaeki @xtk8532704 @SakodaShintaro @TadaKazuto