Skip to content

all: use stretch instead of buster for all builds #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2019
Merged

all: use stretch instead of buster for all builds #1768

merged 1 commit into from
Sep 20, 2019

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Sep 20, 2019

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Summary

Change the Debian version that the Go 1.13 checks, tests, and publishing occurs with to Debian Stretch, instead of Debian Buster.

Goal and scope

When we added tests for Go 1.13 the only image available on DockerHub was based on Debian Stretch. We made a case for publishing a Stretch version for at least a year while Stretch is still in use in docker-library/golang#296 and it was added in docker-library/golang/pull/300 and docker-library/official-images#6597.

Since we're still using Debian Stretch we agreed it would be worthwhile to run our tests and builds on it until we upgrade.

Close #1718

Notes

I left the postgresql fallback install code that pulls the deb from the official postgres apt repo when it's not available in the default system repo. That was also added for Buster because Buster doesn't have the version we need, version 9.6. I left that code there because we're likely to use it soon enough when we move everything to Buster anyway.

Summary of changes

  • Replace uses of the buster image with the stretch image.

Known limitations & issues

N/A

What shouldn't be reviewed

N/A

@leighmcculloch leighmcculloch requested review from brahman81 and ire-and-curses and removed request for brahman81 September 20, 2019 22:33
@leighmcculloch leighmcculloch merged commit d72ea29 into stellar:master Sep 20, 2019
@leighmcculloch leighmcculloch deleted the go113stretch branch September 20, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change version of Debian used on CircleCI from buster to stretch for Go 1.13 builds
2 participants