Skip to content

request to add a stretch build for go1.13rc1 #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leighmcculloch opened this issue Aug 29, 2019 · 0 comments · Fixed by #300
Closed

request to add a stretch build for go1.13rc1 #296

leighmcculloch opened this issue Aug 29, 2019 · 0 comments · Fixed by #300
Labels
Request Request for image modification or feature

Comments

@leighmcculloch
Copy link

leighmcculloch commented Aug 29, 2019

Context

The Go 1.13rc1 image was recently added which is great, but it was only added with a Debian buster variant. While buster is the current stable release, it only moved to stable very recently on July 6th 2019, with stretch moving to oldstable status. oldstable releases like stretch will continue to receive security updates for one year (ref).

Problem

It can be easier for many applications to be updated with new versions of Go than to update versions of Debian. It will take time for everyone to update applications and their dependencies to be compatible with buster. During that period an official Go 1.13 isn't available to folks who are not yet ready to upgrade from stretch, but could be running Go 1.13 on production workloads.

Speaking specifically to my own situation, I'm attempting to use Go 1.13 for stellar/go#1634, but I'm still working through a move to buster.

Proposal / Request

While the stretch debian release is still supported with security updates could we support a Go 1.13 image on stretch to give folks more time to transition to buster while being able to adopt Go 1.13 and run it in development and production workloads?

@wglambert wglambert added the Request Request for image modification or feature label Sep 3, 2019
leighmcculloch added a commit to stellar/go that referenced this issue Sep 20, 2019
Change the Debian version that the Go 1.13 checks, tests, and publishing occurs with to Debian Stretch, instead of Debian Buster.

When we added tests for Go 1.13 the only image available on DockerHub was based on Debian Stretch. We made a case for publishing a Stretch version for at least a year while Stretch is still in use in docker-library/golang#296 and it was added in docker-library/golang/pull/300 and docker-library/official-images#6597.

Since we're still using Debian Stretch we agreed it would be worthwhile to run our tests and builds on it until we upgrade.

I left the postgresql fallback install code that pulls the deb from the official postgres apt repo when it's not available in the default system repo. That was also added for Buster because Buster doesn't have the version we need, version 9.6. I left that code there because we're likely to use it soon enough when we move everything to Buster anyway.

Close #1718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Request Request for image modification or feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants