Skip to content

Change version of Debian used on CircleCI from buster to stretch for Go 1.13 builds #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leighmcculloch opened this issue Sep 5, 2019 · 0 comments · Fixed by #1768
Closed

Change version of Debian used on CircleCI from buster to stretch for Go 1.13 builds #1718

leighmcculloch opened this issue Sep 5, 2019 · 0 comments · Fixed by #1768
Assignees
@leighmcculloch

Comments

@leighmcculloch
Copy link
Member

Change version of Debian used on CircleCI from buster to stretch for Go 1.13 builds, for consistency with the Go 1.12 builds.

In #1542 and #1696 we added Go 1.13 builds using Debian Buster because the official DockerHub images for Go didn't include a stretch variant.

In docker-library/golang#300 a stretch variant was accepted. Once it's gone through review and the image has been built and is available on DockerHub we should change the CircleCI config to use the stretch variant, and then remove the changes to the dependencies that are no longer required.
@leighmcculloch leighmcculloch mentioned this issue Sep 20, 2019
Merged
7 tasks
@leighmcculloch leighmcculloch self-assigned this Sep 20, 2019
leighmcculloch added a commit that referenced this issue Sep 20, 2019
@leighmcculloch
all: use stretch instead of buster for all builds (#1768)
d72ea29 
Change the Debian version that the Go 1.13 checks, tests, and publishing occurs with to Debian Stretch, instead of Debian Buster.

When we added tests for Go 1.13 the only image available on DockerHub was based on Debian Stretch. We made a case for publishing a Stretch version for at least a year while Stretch is still in use in docker-library/golang#296 and it was added in docker-library/golang/pull/300 and docker-library/official-images#6597.

Since we're still using Debian Stretch we agreed it would be worthwhile to run our tests and builds on it until we upgrade.

I left the postgresql fallback install code that pulls the deb from the official postgres apt repo when it's not available in the default system repo. That was also added for Buster because Buster doesn't have the version we need, version 9.6. I left that code there because we're likely to use it soon enough when we move everything to Buster anyway.

Close #1718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leighmcculloch leighmcculloch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

all: use stretch instead of buster for all builds
1 participant
@leighmcculloch