Change pycommon to use swsscommon #10099

liuh-80 · 2022-02-28T04:52:40Z

Why I did it

Switch py-common from swsssdk to swsscommon.

How I did it

Change code and make file to use swsscommon.

How to verify it

Pass all UT and E2E test.

Which release branch to backport (provide reason below if selected)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

liuh-80 · 2022-02-28T08:28:48Z

py_common change will break UT in sonic-platform-daemons, the issue will be fix in this PR: sonic-net/sonic-platform-daemons#246

lgtm-com · 2022-03-04T08:37:36Z

This pull request introduces 1 alert when merging f21d1c8 into c40f04f - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-03-07T06:27:30Z

This pull request introduces 1 alert when merging 45d60b1 into 2ef9d65 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-03-07T08:47:50Z

This pull request introduces 1 alert when merging 5a5f592 into 78e867a - view on LGTM.com

new alerts:

1 for Unused import

liuh-80 · 2022-03-10T04:20:39Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-03-10T04:20:44Z

Pull request contains merge conflicts.

…stcfgd_to_swsscommon

liuh-80 · 2022-03-10T04:48:15Z

This PR is continue of original PR: #7655
And because this PR require many submodule change, for example sonic-utilities change, so this PR will keep in draft status until all change in submodule been merge to master branch, and pass all validation.

lgtm-com · 2022-03-10T05:07:41Z

This pull request introduces 1 alert when merging 1a3a020 into 8601709 - view on LGTM.com

new alerts:

1 for Unused import

qiluo-msft · 2022-03-11T23:20:05Z

import glob

I notice the filename not proper https://github.com/Azure/sonic-buildimage/blob/8d419ca2c59b0f75c24ba4ed73fbdc7df7812260/src/sonic-py-common/tests/device_info_test.py#L16.

Change mock_swsssdk to mock_swsscommon

In reply to: 1065633693

Refers to: src/sonic-py-common/sonic_py_common/device_info.py:1 in 1a3a020. [](commit_id = 1a3a020, deletion_comment = False)

liuh-80 · 2022-03-14T05:19:08Z

import glob

I notice the filename not proper

https://github.com/Azure/sonic-buildimage/blob/8d419ca2c59b0f75c24ba4ed73fbdc7df7812260/src/sonic-py-common/tests/device_info_test.py#L16

.
Change mock_swsssdk to mock_swsscommon

Refers to: src/sonic-py-common/sonic_py_common/device_info.py:1 in 1a3a020. [](commit_id = 1a3a020, deletion_comment = False)

Fixed.

azure-pipelines · 2022-04-24T05:36:53Z

Azure Pipelines successfully started running 1 pipeline(s).

…stcfgd_to_swsscommon

liuh-80 · 2022-05-13T05:16:41Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-05-13T05:16:53Z

Azure Pipelines successfully started running 1 pipeline(s).

…stcfgd_to_swsscommon

liuh-80 · 2022-05-16T05:31:24Z

After merge with latest master branch code, only 1 UT failed and seems not related with code change in this PR: bgp/test_bgp_update_timer.py

liuh-80 · 2022-05-18T01:31:29Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-05-18T01:31:44Z

Azure Pipelines successfully started running 1 pipeline(s).

liuh-80 · 2022-05-20T01:37:17Z

After re-run, still following UT failed:
2022-05-19T00:58:10.3522829Z ERROR bgp/test_bgp_fact.py::test_bgp_facts[128-vlab-02-None] - Failed: Proces...

And same UT failed happened on many other PRs, seems a common issue, will re-run later.

liuh-80 · 2022-05-20T07:21:09Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-05-20T07:21:22Z

Azure Pipelines successfully started running 1 pipeline(s).

liuh-80 · 2022-05-23T05:06:10Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-05-23T05:06:22Z

Azure Pipelines successfully started running 1 pipeline(s).

liuh-80 · 2022-05-24T00:13:42Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-05-24T00:13:54Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2022-05-31T22:26:34Z

rules/sonic-py-common.mk

@@ -4,6 +4,8 @@ ifeq ($(ENABLE_PY2_MODULES), y)
    SONIC_PY_COMMON_PY2 = sonic_py_common-1.0-py2-none-any.whl
    $(SONIC_PY_COMMON_PY2)_SRC_PATH = $(SRC_PATH)/sonic-py-common
    $(SONIC_PY_COMMON_PY2)_DEPENDS += $(SWSSSDK_PY2)
+    $(SONIC_PY_COMMON_PY2)_DEBS_DEPENDS = $(LIBSWSSCOMMON) \


LIBSWSSCOMMON

Does it depend on LIBSWSSCOMMON directly? #Closed

Fixed, remove indirect dependency to LIBSWSSCOMMON.

you fixed py3, but py2 still has the same issue.

vivekrnv · 2022-08-09T02:50:55Z

@liuh-80, @qiluo-msft Can this be backported to 202205? 202205 is still using swsssdk
https://github.com/sonic-net/sonic-buildimage/blob/202205/src/sonic-py-common/sonic_py_common/device_info.py#L11

I've observed some perf difference when running "intfutil -c status".

ncalls  tottime  percall  cumtime  percall filename:lineno(function)
   52    0.003    0.000    1.018    0.020 device_info.py:354(get_platform_info)   (with swsssdk)
   52    0.003    0.000    0.701    0.013 device_info.py:354(get_platform_info)   (with swsscommon)

dgsudharsan · 2022-08-13T04:49:23Z

Request for 202205

qiluo-msft · 2022-08-16T00:46:07Z

@vivekrnv @dgsudharsan Backport of this feature include many PRs in multiple repos, and with dependencies between them. If there is no strong motivation, we will not backport to 202205 and earlier branches.

vivekrnv · 2022-08-16T00:50:29Z

@vivekrnv @dgsudharsan Backport of this feature include many PRs in multiple repos, and with dependencies between them. If there is no strong motivation, we will not backport to 202205 and earlier branches.

Thought so looking at the other comments, the only motivation is perf diff, nothing else

Ubuntu and others added 3 commits February 28, 2022 04:45

Change pycommon to use swsscommon

e38bbc4

Update sonic-platform-daemons to check the fix of UT

e75e9ed

update submodule reference

28a75e2

liuh-80 mentioned this pull request Feb 28, 2022

Fix UT failed cause by change pycommon to use swsscommon sonic-net/sonic-platform-daemons#246

Merged

liuh-80 added 4 commits February 28, 2022 08:53

update submodule reference

5d71fdf

Update reference to sonic-utilies

b470e73

Fix swsscommon side issue

1286cdd

Remove sonic DB config initialize from deviceinfo

f21d1c8

liuh-80 added 2 commits March 4, 2022 09:56

Remove TODO

b14647f

Fix SNMP initialize issue

45d60b1

Fix build error

5a5f592

liuh-80 added 2 commits March 10, 2022 04:40

merge submodel sonic-utilies

ba4f013

Merge remote-tracking branch 'origin/master' into dev/liuh/upgrade_ho…

1a3a020

…stcfgd_to_swsscommon

liuh-80 mentioned this pull request Mar 10, 2022

Replace swsssdk.ConfigDBConnector and SonicDBConfig with swsscommon implementation in sonic-py-common #7655

Closed

4 tasks

Update code by PR comments

a86df70

liuh-80 added 3 commits April 18, 2022 02:36

Revert git submodule change

6843182

Revert submodule reference

d4af931

Revert sub-module change

6a87318

liuh-80 marked this pull request as ready for review April 18, 2022 07:39

liuh-80 requested a review from qiluo-msft as a code owner April 18, 2022 07:39

Merge remote-tracking branch 'origin/master' into dev/liuh/upgrade_ho…

d9060f9

…stcfgd_to_swsscommon

Merge remote-tracking branch 'origin/master' into dev/liuh/upgrade_ho…

f9366ff

…stcfgd_to_swsscommon

qiluo-msft reviewed May 31, 2022

View reviewed changes

Improve dependency

b94d674

liuh-80 dismissed xumia’s stale review via b94d674 June 1, 2022 05:50

liuh-80 requested a review from a team as a code owner June 1, 2022 05:50

qiluo-msft approved these changes Jun 2, 2022

View reviewed changes

liuh-80 merged commit e4ed475 into sonic-net:master Jun 3, 2022

yxieca added the Request for 202205 Branch label Aug 15, 2022

qiluo-msft removed the Request for 202205 Branch label Aug 16, 2022

vivekrnv mentioned this pull request Sep 19, 2023

[202205] [cli] Performance degradation of show/config cli because of swsssdk import #16595

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change pycommon to use swsscommon #10099

Change pycommon to use swsscommon #10099

liuh-80 commented Feb 28, 2022

liuh-80 commented Feb 28, 2022

lgtm-com bot commented Mar 4, 2022

lgtm-com bot commented Mar 7, 2022

lgtm-com bot commented Mar 7, 2022

liuh-80 commented Mar 10, 2022

azure-pipelines bot commented Mar 10, 2022

liuh-80 commented Mar 10, 2022

lgtm-com bot commented Mar 10, 2022

qiluo-msft commented Mar 11, 2022 •

edited

Loading

liuh-80 commented Mar 14, 2022

azure-pipelines bot commented Apr 24, 2022

liuh-80 commented May 13, 2022

azure-pipelines bot commented May 13, 2022

liuh-80 commented May 16, 2022

liuh-80 commented May 18, 2022

azure-pipelines bot commented May 18, 2022

liuh-80 commented May 20, 2022

liuh-80 commented May 20, 2022

azure-pipelines bot commented May 20, 2022

liuh-80 commented May 23, 2022

azure-pipelines bot commented May 23, 2022

liuh-80 commented May 24, 2022

azure-pipelines bot commented May 24, 2022

qiluo-msft May 31, 2022 •

edited

Loading

liuh-80 Jun 1, 2022

qiluo-msft Jun 1, 2022

vivekrnv commented Aug 9, 2022

dgsudharsan commented Aug 13, 2022

qiluo-msft commented Aug 16, 2022

vivekrnv commented Aug 16, 2022 •

edited

Loading

Change pycommon to use swsscommon #10099

Change pycommon to use swsscommon #10099

Conversation

liuh-80 commented Feb 28, 2022

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

liuh-80 commented Feb 28, 2022

lgtm-com bot commented Mar 4, 2022

lgtm-com bot commented Mar 7, 2022

lgtm-com bot commented Mar 7, 2022

liuh-80 commented Mar 10, 2022

azure-pipelines bot commented Mar 10, 2022

liuh-80 commented Mar 10, 2022

lgtm-com bot commented Mar 10, 2022

qiluo-msft commented Mar 11, 2022 • edited Loading

liuh-80 commented Mar 14, 2022

azure-pipelines bot commented Apr 24, 2022

liuh-80 commented May 13, 2022

azure-pipelines bot commented May 13, 2022

liuh-80 commented May 16, 2022

liuh-80 commented May 18, 2022

azure-pipelines bot commented May 18, 2022

liuh-80 commented May 20, 2022

liuh-80 commented May 20, 2022

azure-pipelines bot commented May 20, 2022

liuh-80 commented May 23, 2022

azure-pipelines bot commented May 23, 2022

liuh-80 commented May 24, 2022

azure-pipelines bot commented May 24, 2022

qiluo-msft May 31, 2022 • edited Loading

Choose a reason for hiding this comment

liuh-80 Jun 1, 2022

Choose a reason for hiding this comment

qiluo-msft Jun 1, 2022

Choose a reason for hiding this comment

vivekrnv commented Aug 9, 2022

dgsudharsan commented Aug 13, 2022

qiluo-msft commented Aug 16, 2022

vivekrnv commented Aug 16, 2022 • edited Loading

qiluo-msft commented Mar 11, 2022 •

edited

Loading

qiluo-msft May 31, 2022 •

edited

Loading

vivekrnv commented Aug 16, 2022 •

edited

Loading