-
Notifications
You must be signed in to change notification settings - Fork 175
Fix UT failed cause by change pycommon to use swsscommon #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UT failed cause by change pycommon to use swsscommon #246
Conversation
Code in this PR will be test in another PR: |
Could you add "UT failed" message into PR description? |
Fixed, Add UT error message to PR description. The original error log can be found here: |
Will push a update later, the UT issue is:
However, because we change sonic_py_common to use swsscommon, so real version of swsscommon been load before we load mock lib. then the UT break. So will check if can load mock lib first by change the code orider. |
@@ -18,6 +18,7 @@ | |||
# Add mocked_libs path so that the file under test can load mocked modules from there | |||
mocked_libs_path = os.path.join(tests_path, "mocked_libs") | |||
sys.path.insert(0, mocked_libs_path) | |||
from sonic_py_common import daemon_base, device_info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is same as L13. I think it will be ignored.
Do you want to remove L13? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, this is a mistake.
Fix UT failed cause by change sonic_py_common to use swss_common
Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)