Skip to content

[202205] [cli] Performance degradation of show/config cli because of swsssdk import #16595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vivekrnv opened this issue Sep 19, 2023 · 2 comments
Assignees
Labels
Triaged this issue has been triaged

Comments

@vivekrnv
Copy link
Contributor

vivekrnv commented Sep 19, 2023

Description

On the latest 202205 image, a diff of 0.2 - 0.3 sec is observed (for slower CPU's) when running show cli's

Steps to reproduce the issue:

  1. time python3 -c "from sonic_py_common import device_info"
  2. run the same command on a 20205 image built before this change Loosen the redis version requirement sonic-py-swsssdk#138

Describe the results you received:

time diff of 0.2 - 0.3 sec per run. This is reflected in most of the show cli's since many of them import device_info which is still using swsssdk in 202205.

Problem is in the redis package used by swsssdk. It was recently bumped to 5.0.0 and the import is taking more time compared to 3.5.3

There was some discussion on moving away from swsssdk for sonic_py_common here but the effort is discontinued, #10099 (comment)

That change should fix this.

Describe the results you expected:

No perf degradation

@judyjoseph
Copy link
Contributor

As mentioned here #10099 (comment), it is tough to move to swsscommon in 202205. @yxieca can we add this to 202205 release notes ?

@judyjoseph judyjoseph added the Triaged this issue has been triaged label Sep 27, 2023
@yxieca
Copy link
Contributor

yxieca commented Oct 13, 2023

Release notes updated.

@yxieca yxieca closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triaged this issue has been triaged
Projects
None yet
Development

No branches or pull requests

3 participants