Skip to content

CoPP Neighbor Miss Trap and Other Enhancements HLD #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

CoPP Neighbor Miss Trap and Other Enhancements HLD #1943

merged 2 commits into from
Jun 9, 2025

Conversation

rminnikanti
Copy link
Contributor

@rminnikanti rminnikanti commented Mar 7, 2025 •
edited
Loading

HLD for CoPP Neighbor Miss Trap type support and Other CoPP Enhancements

What we did:

  • Added support for new Neighbor Miss trap type and its default CoPP configuration.
  • Introduced SAI enum capability query in orchagent to identify SAI neighbor miss trap support and publish the supported trap types to STATE_DB for application visibility
  • Introduced CoPP CLI support to display trap CoPP configuration and their status.

PRs:

Repository PR Title State
sonic-swss-common sonic-net/sonic-swss-common#1010 PR Status
sonic-sairedis sonic-net/sonic-sairedis#1586 PR Status
sonic-swss sonic-net/sonic-swss#3624 PR Status
sonic-buildimage sonic-net/sonic-buildimage#22406 PR Status
sonic-utilities sonic-net/sonic-utilities#3863 PR Status

@mssonicbld
Copy link
Collaborator

/azp run

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 7, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@prsunny
Copy link
Contributor

prsunny commented Mar 12, 2025

@prabhataravind , please review as this should cover subnet trap.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@rck-innovium rck-innovium mentioned this pull request Mar 25, 2025
Merged
selva-nexthop
selva-nexthop reviewed Mar 25, 2025
View reviewed changes
selva-nexthop
selva-nexthop reviewed Mar 25, 2025
View reviewed changes
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

prsunny
prsunny reviewed Mar 25, 2025
View reviewed changes
@dgsudharsan
Copy link
Contributor

Can you please test trap flow counters with this feature?

@zhangyanzhao zhangyanzhao moved this to 🏗 In Progress in SONiC 202505 Release Apr 1, 2025
rminnikanti added a commit to rminnikanti/sonic-swss that referenced this pull request Apr 22, 2025
@rminnikanti
CoPP neighbor miss trap and enhancements
36c5182 
What I did
* Added neighbor_miss trap type support
* enum capability query for hostif trap type
* Added trap hw_status field to state_db

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-swss that referenced this pull request May 10, 2025
@rminnikanti
[orchagent] CoPP neighbor miss trap and enhancements
7137a39 
What I did
* Added neighbor_miss trap type support
* enum capability query for hostif trap type
* Added trap hw_status field to state_db

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-utilities that referenced this pull request May 10, 2025
@rminnikanti
Added CoPP show configuration command
b6a90e0 
What I did:
CoPP show commands:
* show copp configuration
* show copp configuration detailed --trapid <trap_id>
* show copp configuration detailed --group <group>

Added UT for the CLI commands.

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-buildimage that referenced this pull request May 10, 2025
@rminnikanti
[copp_cfg.json]: Default config for neighbor_miss trap type
687dc81 
Added copp default configuration for neighbor_miss trap type
to copp_cfg.json

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-utilities that referenced this pull request May 19, 2025
@rminnikanti
Added CoPP show configuration command
379adaf 
What I did:
CoPP show commands:
* show copp configuration
* show copp configuration detailed --trapid <trap_id>
* show copp configuration detailed --group <group>

Added UT for the CLI commands.

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-buildimage that referenced this pull request May 19, 2025
@rminnikanti
[copp_cfg.json]: Default config for neighbor_miss trap type
67052ba 
Added copp default configuration for neighbor_miss trap type
to copp_cfg.json

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-swss that referenced this pull request May 19, 2025
@rminnikanti
[orchagent] CoPP neighbor miss trap and enhancements
b922219 
What I did
* Added neighbor_miss trap type support
* enum capability query for hostif trap type
* Added trap hw_status field to state_db

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-sairedis that referenced this pull request May 19, 2025
@rminnikanti
[vslib]: hostif enum capability query API support
cbb7167 
1. vslib support for SAI_OBJECT_TYPE_HOSTIF_TRAP,
   attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE
2. Added UT for SAI_OBJECT_TYPE_HOSTIF_TRAP
3. Added UT for SAI_OBJECT_TYPE_DEBUG_COUNTER

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-utilities that referenced this pull request May 22, 2025
@rminnikanti
Added CoPP show configuration command
b69ff1d 
What I did:
CoPP show commands:
* show copp configuration
* show copp configuration detailed --trapid <trap_id>
* show copp configuration detailed --group <group>

Added UT for the CLI commands.

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-swss-common that referenced this pull request May 22, 2025
@rminnikanti
[schema]: Add CoPP trap capability table to state_db
b761c49 
HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-buildimage that referenced this pull request May 22, 2025
@rminnikanti
[copp_cfg.json]: Default config for neighbor_miss trap type
8d36b0a 
Added copp default configuration for neighbor_miss trap type
to copp_cfg.json

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-swss that referenced this pull request May 22, 2025
@rminnikanti
[orchagent] CoPP neighbor miss trap and enhancements
1fe2606 
What I did
* Added neighbor_miss trap type support
* enum capability query for hostif trap type
* Added trap hw_status field to state_db

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
@rminnikanti rminnikanti requested a review from dgsudharsan May 24, 2025 04:22
rminnikanti added a commit to rminnikanti/sonic-buildimage that referenced this pull request May 26, 2025
@rminnikanti
[copp_cfg.json]: Default config for neighbor_miss trap type
3801473 
Added copp default configuration for neighbor_miss trap type
to copp_cfg.json

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
@rminnikanti rminnikanti requested a review from selva-nexthop May 28, 2025 11:19
rminnikanti added a commit to rminnikanti/sonic-sairedis that referenced this pull request May 30, 2025
@rminnikanti
[vslib]: hostif enum capability query API support
0a7a42b 
1. vslib support for SAI_OBJECT_TYPE_HOSTIF_TRAP,
   attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE
2. Added UT for SAI_OBJECT_TYPE_HOSTIF_TRAP
3. Added UT for SAI_OBJECT_TYPE_DEBUG_COUNTER

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
qiluo-msft pushed a commit to sonic-net/sonic-swss-common that referenced this pull request May 30, 2025
@rminnikanti
[schema]: Add CoPP trap capability table to state_db (#1010)
cbb7176 
What I did

Added the COPP_TRAP_CAPABILITY_TABLE table definition to schema.h

Why I did it

Details in HLD: sonic-net/SONiC#1943
@anilpannala anilpannala moved this from 🏗 In Progress to MovedToBacklog in SONiC 202505 Release May 30, 2025
rminnikanti added a commit to rminnikanti/sonic-swss that referenced this pull request May 31, 2025
@rminnikanti
[orchagent] CoPP neighbor miss trap and enhancements
df140c2 
What I did
* Added neighbor_miss trap type support
* enum capability query for hostif trap type
* Added trap hw_status field to state_db

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-buildimage that referenced this pull request May 31, 2025
@rminnikanti
[copp_cfg.json]: Default config for neighbor_miss trap type
6065d10 
Added copp default configuration for neighbor_miss trap type
to copp_cfg.json

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-sairedis that referenced this pull request May 31, 2025
@rminnikanti
[vslib]: hostif enum capability query API support
55ff1c5 
1. vslib support for SAI_OBJECT_TYPE_HOSTIF_TRAP,
   attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE
2. Added UT for SAI_OBJECT_TYPE_HOSTIF_TRAP
3. Added UT for SAI_OBJECT_TYPE_DEBUG_COUNTER

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
@prsunny
Copy link
Contributor

prsunny commented Jun 2, 2025

@dgsudharsan , would you approve?

@prsunny
Copy link
Contributor

prsunny commented Jun 9, 2025 •
edited
Loading

@prabhataravind , Merging the HLD. Please review #3624

@prsunny prsunny merged commit 9007c5e into sonic-net:master Jun 9, 2025
1 check passed
rminnikanti added a commit to rminnikanti/sonic-utilities that referenced this pull request Jun 10, 2025
@rminnikanti
Added CoPP show configuration command
a3b4be1 
What I did:
CoPP show commands:
* show copp configuration
* show copp configuration detailed --trapid <trap_id>
* show copp configuration detailed --group <group>

Added UT for the CLI commands.

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti added a commit to rminnikanti/sonic-swss that referenced this pull request Jun 10, 2025
@rminnikanti
[orchagent] CoPP neighbor miss trap and enhancements
f315a94 
What I did
* Added neighbor_miss trap type support
* enum capability query for hostif trap type
* Added trap hw_status field to state_db
* Added UT and mock tests

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
saiarcot895 added a commit to sonic-net/sonic-sairedis that referenced this pull request Jun 10, 2025
@rminnikanti @saiarcot895
[vslib]: hostif enum capability query API support (#1586)
d24b313 
* [vslib]: hostif enum capability query API support

1. vslib support for SAI_OBJECT_TYPE_HOSTIF_TRAP,
   attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE
2. Added UT for SAI_OBJECT_TYPE_HOSTIF_TRAP
3. Added UT for SAI_OBJECT_TYPE_DEBUG_COUNTER

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>

* Added comments in unittest

Added unittest comments to satisfy PR checks.

Signed-off-by: Ravi Minnikanti <[email protected]>

---------

Signed-off-by: Ravi Minnikanti <[email protected]>
Co-authored-by: Saikrishna Arcot <[email protected]>
qiluo-msft pushed a commit to sonic-net/sonic-utilities that referenced this pull request Jun 13, 2025
@rminnikanti
[copp]: Added CoPP show configuration commands (#3863)
5ea861d 
What I did:

Added CoPP show commands:

show copp configuration
show copp configuration detailed --trapid <trap_id>
show copp configuration detailed --group <group>
Added UT for the CLI commands.

Why I did it

Details in HLD: sonic-net/SONiC#1943

How to verify it

Verified with UT
rminnikanti added a commit to rminnikanti/sonic-swss that referenced this pull request Jun 17, 2025
@rminnikanti
[orchagent] CoPP neighbor miss trap and enhancements
1a54167 
What I did
* Added neighbor_miss trap type support
* enum capability query for hostif trap type
* Added trap hw_status field to state_db
* Added UT and mock tests

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@prsunny prsunny prsunny approved these changes

@selva-nexthop selva-nexthop selva-nexthop approved these changes

@prabhataravind prabhataravind Awaiting requested review from prabhataravind

Assignees

@rminnikanti rminnikanti

Labels
None yet
Projects
SONiC 202505 Release
Status: MovedToBacklog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rminnikanti @mssonicbld @prsunny @dgsudharsan @selva-nexthop