CoPP Neighbor Miss Trap and Other Enhancements HLD #1943

rminnikanti · 2025-03-07T04:05:49Z

HLD for CoPP Neighbor Miss Trap type support and Other CoPP Enhancements

What we did:

Added support for new Neighbor Miss trap type and its default CoPP configuration.
Introduced SAI enum capability query in orchagent to identify SAI neighbor miss trap support and publish the supported trap types to STATE_DB for application visibility
Introduced CoPP CLI support to display trap CoPP configuration and their status.

PRs:

Repository	PR Title	State	Context
sonic-buildimage	sonic-net/sonic-buildimage#22406
sonic-swss	sonic-net/sonic-swss#3624
sonic-swss-common	sonic-net/sonic-swss-common#1010
sonic-sairedis	sonic-net/sonic-sairedis#1586
sonic-utilities	sonic-net/sonic-utilities#3863

mssonicbld · 2025-03-07T04:05:51Z

/azp run

linux-foundation-easycla · 2025-03-07T04:05:53Z

The committers listed above are authorized under a signed CLA.

✅ login: rminnikanti / name: Ravi Minnikanti (3972424, 1fba163)

azure-pipelines · 2025-03-07T04:05:58Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

prsunny · 2025-03-12T20:09:22Z

@prabhataravind , please review as this should cover subnet trap.

mssonicbld · 2025-03-21T17:17:48Z

/azp run

azure-pipelines · 2025-03-21T17:17:54Z

No pipelines are associated with this pull request.

mssonicbld · 2025-03-21T18:00:10Z

/azp run

azure-pipelines · 2025-03-21T18:00:26Z

No pipelines are associated with this pull request.

mssonicbld · 2025-03-24T18:04:39Z

/azp run

azure-pipelines · 2025-03-24T18:04:45Z

No pipelines are associated with this pull request.

mssonicbld · 2025-03-25T03:53:09Z

/azp run

azure-pipelines · 2025-03-25T03:53:15Z

No pipelines are associated with this pull request.

selva-nexthop · 2025-03-25T06:10:03Z

doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md

+
+During initialization, Copporch in Orchagent will perform an SAI enum capability query to identify supported trap types and maintain them in a local list called `supported_trap_ids`.
+
+Additionally, Copporch will maintain a list called `default_supported_trap_ids`, which contains currently supported trap IDs in copporch in orchagent. If the SAI does not support the enum capability query API, Copporch will assume that the `default_supported_trap_ids` are supported for backward compatibility.


the existing default_supported_trap_ids is vendor specific?

default_supported_trap_ids is not vendor specific. This will have all the enums that are currently known to Orchagent. New trap types like neighbor miss won't be part of this list.

Idea is to have backward compatibility with existing behavior if the SAI enum capability query for trap type attribute is not supported.

selva-nexthop · 2025-03-25T06:16:55Z

doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md

+### 7.4 Schema Changes
+
+State DB will have a new table called COPP_TRAP_CAPABILITY_TABLE which will have the supported trap types. 
+Introducing new value pair "oper_status" field in existing COPP_TRAP_TABLE, to track the operational status of the trap type.


What happens if there is any change happens in SAI capabilities (e..g firmware upgrade)? Will it trigger any daemon restart? how this list will be updated for such changes?

When syncd docker restarts, it triggers a restart of swss. During the initialization of CoppOrch, an enum capability query is performed. This occurs in both warmboot and coldboot scenarios. This process is similar to the flow in other Orch's, such as aclorch.cpp
Can you elaborate the use case?

selva-nexthop · 2025-03-25T06:23:08Z

doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md

+          "queue": "1",
+          "meter_type":"packets",
+          "mode":"sr_tcm",
+          "cir":"200",


How the cir, cbs, and red_action values are derived? These values might be strict for high-traffic environments causing unnecessary packet drops.

These values are posted by Microsoft in the SAI PR based on their internal tests:
opencomputeproject/SAI#2066 (comment)

selva-nexthop · 2025-03-25T06:26:55Z

doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md

+
+An existing test case in the sonic-mgmt PTF framework tests VLAN subnet route traffic policing under the default CoPP configuration.
+
+A new test case will be introduced to verify the neighbor miss trap configuration with its default settings in copp_cfg.json using VLAN subnet route traffic. This test case will also update/empty/NULL configuration for neighbor miss in CONFIG_DB to override the default settings and verify the operational status of neighbor miss in the CLI output accordingly.


can we add real-world ARP traffic stress tests ?

Neighbor miss traffic does not police ARP traffic. It is to police IP traffic that is trapped to the CPU when the L3 lookup for ARP resolution has no entry for the neighbor. ARP traffic has a separate copp configuration in copp_cfg.json.

selva-nexthop · 2025-03-25T06:34:01Z

doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md

+A new trap group queue1_group3 will be added to the default configuration with the following settings:
+
+```json
+  "queue1_group3": {


Rationale behind using queue1_group3?
If queue1_group3 is congested, Neighbor Miss traffic may be dropped while other less critical packets get through.

selva-nexthop · 2025-03-25T06:36:58Z

doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md

+### 10.1 Show Commands
+
+A new CLI command, `show copp configuration`, is being introduced. The purpose of this command is to display the CoPP configuration applied to SAI. The command will retrieve configuration from copp_cfg.json and CONFIG_DB. Additionally, the command will display the operational status of the trap types retrieved from STATE_DB.
+


Can we measure the performance of this CLI in scale/stress environment? It is retrieving from multiple sources and it might take several seconds in large-scale switches.

At present, traps supported by Orchagent are 47 and total traps defined by SAI are only ~67.
Trap configurations are not expected to grow in large-scale networks.

selva-nexthop · 2025-03-25T06:39:08Z

doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md

+
+## 11. Warmboot and Fastboot Design Impact
+
+No warmboot and fastboot impact is expected for this feature.


how CoPP changes apply during warmboot?

mssonicbld · 2025-03-25T09:01:28Z

/azp run

azure-pipelines · 2025-03-25T09:01:35Z

No pipelines are associated with this pull request.

doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md

dgsudharsan · 2025-03-26T04:07:23Z

Can you please test trap flow counters with this feature?

What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

What I did: CoPP show commands: * show copp configuration * show copp configuration detailed --trapid <trap_id> * show copp configuration detailed --group <group> Added UT for the CLI commands. HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

vslib support for SAI_OBJECT_TYPE_HOSTIF_TRAP, attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

Added copp default configuration for neighbor_miss trap type to copp_cfg.json HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

What I did: CoPP show commands: * show copp configuration * show copp configuration detailed --trapid <trap_id> * show copp configuration detailed --group <group> Added UT for the CLI commands. HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

vslib support for SAI_OBJECT_TYPE_HOSTIF_TRAP, attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

What I did: CoPP show commands: * show copp configuration * show copp configuration detailed --trapid <trap_id> * show copp configuration detailed --group <group> Added UT for the CLI commands. HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

Signed-off-by: Ravi Minnikanti <[email protected]>

mssonicbld · 2025-04-23T19:25:40Z

/azp run

azure-pipelines · 2025-04-23T19:25:46Z

No pipelines are associated with this pull request.

What I did: CoPP show commands: * show copp configuration * show copp configuration detailed --trapid <trap_id> * show copp configuration detailed --group <group> Added UT for the CLI commands. HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

vslib support for SAI_OBJECT_TYPE_HOSTIF_TRAP, attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

rminnikanti · 2025-04-25T16:40:59Z

Can you please test trap flow counters with this feature?

trap counters tested.

prsunny · 2025-05-01T20:03:19Z

@rminnikanti , can you please follow the description template and update all the associated PRs?

Added copp default configuration for neighbor_miss trap type to copp_cfg.json HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

dgsudharsan · 2025-05-02T23:13:25Z

doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md

+
+During initialization, Copporch in Orchagent will perform an SAI enum capability query to identify supported trap types and maintain them in a local list called `supported_trap_ids`.
+
+Additionally, Copporch will maintain a list called `default_supported_trap_ids`, which contains currently supported trap IDs in copporch in orchagent. If the SAI does not support the enum capability query API, Copporch will assume that the `default_supported_trap_ids` are supported for backward compatibility.


I don't support adding default_supported_trap_ids. If the query API is not present, we should treat it as any configuration and push to the SAI. This will ensure the backward compatibility as well

Hi @dgsudharsan,

The default_supported_trap_ids list ensures backward compatibility. It includes all currently known traps used by orchagent, except for "neighbor_miss". This ensures that all existing trap configurations are pushed to the SAI, even if the query API isn't available. It also prevents orchagent from throwing exceptions in cases where the vendor SAI does not support "neighbor_miss" and using a different method to handle neighbor_miss traffic.

In summary, all current traps are pushed to SAI even if query API is not available only neighbor_miss and future traps need query API availability.

prsunny requested review from dgsudharsan and prabhataravind March 12, 2025 20:08

rck-innovium mentioned this pull request Mar 25, 2025

Hostif trap type for Subnet routes opencomputeproject/SAI#2066

Merged

selva-nexthop reviewed Mar 25, 2025

View reviewed changes

prsunny reviewed Mar 25, 2025

View reviewed changes

doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md Show resolved Hide resolved

zhangyanzhao added this to SONiC 202505 Release Apr 1, 2025

zhangyanzhao moved this to 🏗 In Progress in SONiC 202505 Release Apr 1, 2025

zhangyanzhao assigned rminnikanti Apr 1, 2025

rminnikanti added a commit to rminnikanti/sonic-swss-common that referenced this pull request Apr 22, 2025

[schema]: Add CoPP trap capability table to state_db

bf27148

HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>

rminnikanti mentioned this pull request Apr 22, 2025

[schema]: Add CoPP trap capability table to state_db sonic-net/sonic-swss-common#1010

Open

This was referenced Apr 22, 2025

[vslib]: hostif enum capability query API support sonic-net/sonic-sairedis#1586

Open

[orchagent] CoPP neighbor miss trap and enhancements sonic-net/sonic-swss#3624

Open

rminnikanti mentioned this pull request Apr 22, 2025

[copp_cfg.json]: Default config for neighbor_miss trap type sonic-net/sonic-buildimage#22406

Open

10 tasks

rminnikanti mentioned this pull request Apr 23, 2025

[copp]: Added CoPP show configuration commands sonic-net/sonic-utilities#3863

Open

rminnikanti added 2 commits April 24, 2025 00:44

CoPP Neighbor Miss Trap And Enhancements HLD

3972424

Signed-off-by: Ravi Minnikanti <[email protected]>

Changed oper_status to hw_status

1fba163

Signed-off-by: Ravi Minnikanti <[email protected]>

rminnikanti force-pushed the neighbor_miss branch from 6582e97 to 1fba163 Compare April 23, 2025 19:25

prsunny approved these changes Apr 24, 2025

View reviewed changes

dgsudharsan suggested changes May 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CoPP Neighbor Miss Trap and Other Enhancements HLD #1943

CoPP Neighbor Miss Trap and Other Enhancements HLD #1943

rminnikanti commented Mar 7, 2025 •

edited

Loading

mssonicbld commented Mar 7, 2025

linux-foundation-easycla bot commented Mar 7, 2025 •

edited

Loading

azure-pipelines bot commented Mar 7, 2025

prsunny commented Mar 12, 2025

mssonicbld commented Mar 21, 2025

azure-pipelines bot commented Mar 21, 2025

mssonicbld commented Mar 21, 2025

azure-pipelines bot commented Mar 21, 2025

mssonicbld commented Mar 24, 2025

azure-pipelines bot commented Mar 24, 2025

mssonicbld commented Mar 25, 2025

azure-pipelines bot commented Mar 25, 2025

selva-nexthop Mar 25, 2025

rminnikanti Mar 25, 2025

selva-nexthop Mar 25, 2025

rminnikanti Mar 25, 2025

selva-nexthop Mar 25, 2025

rminnikanti Mar 25, 2025

selva-nexthop Mar 25, 2025

rminnikanti Mar 25, 2025 •

edited

Loading

selva-nexthop Mar 25, 2025

selva-nexthop Mar 25, 2025

rminnikanti Mar 25, 2025

selva-nexthop Mar 25, 2025

mssonicbld commented Mar 25, 2025

azure-pipelines bot commented Mar 25, 2025

dgsudharsan commented Mar 26, 2025

mssonicbld commented Apr 23, 2025

azure-pipelines bot commented Apr 23, 2025

rminnikanti commented Apr 25, 2025

prsunny commented May 1, 2025

dgsudharsan May 2, 2025

rminnikanti May 3, 2025


		During initialization, Copporch in Orchagent will perform an SAI enum capability query to identify supported trap types and maintain them in a local list called `supported_trap_ids`.

		Additionally, Copporch will maintain a list called `default_supported_trap_ids`, which contains currently supported trap IDs in copporch in orchagent. If the SAI does not support the enum capability query API, Copporch will assume that the `default_supported_trap_ids` are supported for backward compatibility.


		An existing test case in the sonic-mgmt PTF framework tests VLAN subnet route traffic policing under the default CoPP configuration.

		A new test case will be introduced to verify the neighbor miss trap configuration with its default settings in copp_cfg.json using VLAN subnet route traffic. This test case will also update/empty/NULL configuration for neighbor miss in CONFIG_DB to override the default settings and verify the operational status of neighbor miss in the CLI output accordingly.

		### 10.1 Show Commands

		A new CLI command, `show copp configuration`, is being introduced. The purpose of this command is to display the CoPP configuration applied to SAI. The command will retrieve configuration from copp_cfg.json and CONFIG_DB. Additionally, the command will display the operational status of the trap types retrieved from STATE_DB.


		## 11. Warmboot and Fastboot Design Impact

		No warmboot and fastboot impact is expected for this feature.

CoPP Neighbor Miss Trap and Other Enhancements HLD #1943

Are you sure you want to change the base?

CoPP Neighbor Miss Trap and Other Enhancements HLD #1943

Conversation

rminnikanti commented Mar 7, 2025 • edited Loading

mssonicbld commented Mar 7, 2025

linux-foundation-easycla bot commented Mar 7, 2025 • edited Loading

azure-pipelines bot commented Mar 7, 2025

prsunny commented Mar 12, 2025

mssonicbld commented Mar 21, 2025

azure-pipelines bot commented Mar 21, 2025

mssonicbld commented Mar 21, 2025

azure-pipelines bot commented Mar 21, 2025

mssonicbld commented Mar 24, 2025

azure-pipelines bot commented Mar 24, 2025

mssonicbld commented Mar 25, 2025

azure-pipelines bot commented Mar 25, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rminnikanti Mar 25, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mssonicbld commented Mar 25, 2025

azure-pipelines bot commented Mar 25, 2025

dgsudharsan commented Mar 26, 2025

mssonicbld commented Apr 23, 2025

azure-pipelines bot commented Apr 23, 2025

rminnikanti commented Apr 25, 2025

prsunny commented May 1, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rminnikanti commented Mar 7, 2025 •

edited

Loading

linux-foundation-easycla bot commented Mar 7, 2025 •

edited

Loading

rminnikanti Mar 25, 2025 •

edited

Loading