[orchagent] CoPP neighbor miss trap and enhancements #3624
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti
force-pushed
the
neighbor_miss
branch
from
4426b26 to
878b552
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny @kcudnik PR check compilation failing because of dependency on sonic-swss-common PR - sonic-net/sonic-swss-common#1010 |
|
there is no way to run code without dependency checked in, technically you could modify azure pipeline to pull swss common at specific commit, compile it and then build against that, but this is not standard approach and it would break everything else |
|
Thank you for your response. Can the dependency PR be merged to allow the PR checks to run on this PR? |
| }; | ||
|
|
||
| const vector<sai_hostif_trap_type_t> default_supported_trap_ids = { |
There was a problem hiding this comment.
As mentioned in the HLD, It is better to install the trap if the query API isn't available. This would ensure we do not have to edit this in the future
There was a problem hiding this comment.
Hi @dgsudharsan,
The default_supported_trap_ids list ensures backward compatibility. It includes all currently known traps used by orchagent, except for "neighbor_miss". This ensures that all existing trap configurations are pushed to the SAI, even if the query API isn't available. It also prevents orchagent from throwing exceptions in cases where the vendor SAI does not support "neighbor_miss" and using a different method to handle neighbor_miss traffic.
In summary, all current traps are pushed to SAI even if query API is not available only neighbor_miss and future traps need query API availability.
What I did
PR Dependencies
Why I did it
HLD: sonic-net/SONiC#1943
How I verified it
Verified with test_copp.py DVS test
Signed-off-by: Ravi Minnikanti [email protected]