Skip to content

Commit 1fba163

Browse files
committed
Changed oper_status to hw_status
Signed-off-by: Ravi Minnikanti <[email protected]>
1 parent 3972424 commit 1fba163

File tree

1 file changed

+34
-33
lines changed

1 file changed

+34
-33
lines changed

doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md

+34-33
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ A new trap group queue1_group3 will be added to the default configuration with t
135135
### 7.4 Schema Changes
136136

137137
State DB will have a new table called COPP_TRAP_CAPABILITY_TABLE which will have the supported trap types.
138-
Introducing new value pair "oper_status" field in existing COPP_TRAP_TABLE, to track the operational status of the trap type.
138+
Introducing new value pair "hw_status" field in existing COPP_TRAP_TABLE, to track the operational status of the trap type.
139139

140140
#### State-DB Schema
141141

@@ -147,13 +147,13 @@ New COPP_TRAP_CAPABILITY_TABLE
147147
trap_ids = STRING
148148
```
149149

150-
oper_status field in COPP_TRAP_TABLE
150+
hw_status field in COPP_TRAP_TABLE
151151

152152
```
153153
key = "COPP_TRAP_TABLE|<trap_name>"
154154
; field = value
155155
state = STRING
156-
oper_status = STRING
156+
hw_status = STRING
157157
```
158158

159159
#### Example
@@ -163,7 +163,7 @@ oper_status field in COPP_TRAP_TABLE
163163
"type": "hash",
164164
"value": {
165165
"state": "ok",
166-
"oper_status": "installed"
166+
"hw_status": "installed"
167167
},
168168
"ttl": -0.001,
169169
"expireat": 1741187975.7037652
@@ -173,7 +173,7 @@ oper_status field in COPP_TRAP_TABLE
173173
"COPP_TRAP_CAPABILITY_TABLE|traps": {
174174
"type": "hash",
175175
"value": {
176-
"trap_id_list": "stp,lacp,eapol,lldp,pvrst,igmp_query,igmp_leave,igmp_v1_report,igmp_v2_report,igmp_v3_report,sample_packet,udld,arp_req,arp_resp,dhcp,ospf,pim,vrrp,dhcpv6,ospfv6,vrrpv6,neigh_discovery,mld_v1_v2,mld_v1_report,mld_v1_done,mld_v2_report,src_nat_miss,dest_nat_miss,isis,ip2me,ssh,snmp,bgp,bgpv6,bfd,bfdv6,bfd_micro,bfdv6_micro,ldp,l3_mtu_error,ttl_error"
176+
"trap_ids": "stp,lacp,eapol,lldp,pvrst,igmp_query,igmp_leave,igmp_v1_report,igmp_v2_report,igmp_v3_report,sample_packet,udld,arp_req,arp_resp,dhcp,ospf,pim,vrrp,dhcpv6,ospfv6,vrrpv6,neigh_discovery,mld_v1_v2,mld_v1_report,mld_v1_done,mld_v2_report,src_nat_miss,dest_nat_miss,isis,ip2me,ssh,snmp,bgp,bgpv6,bfd,bfdv6,bfd_micro,bfdv6_micro,ldp,l3_mtu_error,ttl_error"
177177
},
178178
"ttl": -0.001,
179179
"expireat": 1738645275.8970804
@@ -220,44 +220,45 @@ show
220220
In below example BGP and BGPv6 traps are not installed as feature is disabled.
221221

222222
```bash
223-
root@0ed93b5ee13c:/# show copp configuration
224-
TrapId Trap Group CBS CIR mode meter_type oper_status
225-
--------------- ------------- ----- ----- ------- ------------ ------------
226-
arp_req queue4_group2 600 600 packets sr_tcm installed
227-
arp_resp queue4_group2 600 600 packets sr_tcm installed
228-
bgp queue4_group1 6000 6000 packets sr_tcm not_installed
229-
bgpv6 queue4_group1 6000 6000 packets sr_tcm not_installed
230-
dest_nat_miss queue1_group2 600 600 packets sr_tcm installed
231-
dhcp queue4_group3 100 100 packets sr_tcm installed
232-
dhcpv6 queue4_group3 100 100 packets sr_tcm installed
233-
eapol queue4_group1 6000 6000 packets sr_tcm installed
234-
ip2me queue1_group1 6000 6000 packets sr_tcm installed
235-
lacp queue4_group1 6000 6000 packets sr_tcm installed
236-
lldp queue4_group3 100 100 packets sr_tcm installed
237-
neigh_discovery queue4_group2 600 600 packets sr_tcm installed
238-
neighbor_miss queue1_group3 600 600 packets sr_tcm not_installed
239-
src_nat_miss queue1_group2 600 600 packets sr_tcm installed
240-
udld queue4_group3 100 100 packets sr_tcm installed
223+
admin@sonic:~$ show copp configuration
224+
TrapId Trap Group Action CBS CIR Meter Type Mode HW Status
225+
--------------- ------------- -------- ----- ----- ------------ ------ -------------
226+
arp_req queue4_group2 copy 600 600 packets sr_tcm installed
227+
arp_resp queue4_group2 copy 600 600 packets sr_tcm installed
228+
bgp queue4_group1 trap 6000 6000 packets sr_tcm not-installed
229+
bgpv6 queue4_group1 trap 6000 6000 packets sr_tcm not-installed
230+
dest_nat_miss queue1_group2 trap 600 600 packets sr_tcm installed
231+
dhcp queue4_group3 trap 100 100 packets sr_tcm installed
232+
dhcpv6 queue4_group3 trap 100 100 packets sr_tcm installed
233+
eapol queue4_group1 trap 6000 6000 packets sr_tcm installed
234+
ip2me queue1_group1 trap 6000 6000 packets sr_tcm installed
235+
lacp queue4_group1 trap 6000 6000 packets sr_tcm installed
236+
lldp queue4_group3 trap 100 100 packets sr_tcm installed
237+
neigh_discovery queue4_group2 copy 600 600 packets sr_tcm installed
238+
neighbor_miss queue1_group3 trap 200 200 packets sr_tcm installed
239+
sample_packet queue2_group1 trap 1000 1000 packets sr_tcm not-installed
240+
src_nat_miss queue1_group2 trap 600 600 packets sr_tcm installed
241+
udld queue4_group3 trap 100 100 packets sr_tcm installed
241242
```
242243

243244
**Detailed View Example**:
244245

245246
```bash
246-
root@0ed93b5ee13c:/# show copp configuration detailed --trapid neighbor_miss
247+
admin@sonic:~$ show copp configuration detailed --trapid neighbor_miss
247248
Trap Group.................. queue1_group3
248-
queue....................... 1
249-
Trap Priority............... 1
250249
Trap Action................. trap
251-
Meter Type.................. packets
252-
Mode........................ sr_tcm
250+
Trap Priority............... 1
251+
Queue....................... 1
253252
CBS......................... 200
254253
CIR......................... 200
255-
Green Action................ forward
254+
Meter Type.................. packets
255+
Mode........................ sr_tcm
256256
Yellow Action............... forward
257+
Green Action................ forward
257258
Red Action.................. drop
258-
Oper Status................. not_installed
259+
HW Status................... installed
259260

260-
root@0ed93b5ee13c:/# show copp configuration detailed --group queue1_group3
261+
admin@sonic:~$ show copp configuration detailed --group queue1_group3
261262
Trap Id(s).................. neighbor_miss
262263
queue....................... 1
263264
Trap Priority............... 1
@@ -282,7 +283,7 @@ No warmboot and fastboot impact is expected for this feature.
282283
#### 12.1.1. SWSS Unit Test Cases
283284

284285
* **Neighbor Miss default configuration verification:** Default copp group and trap configuration of neighbor miss will be added to test_copp.py to verify the default configuration.
285-
* **Trap oper_status verification:** Existing test cases currently verify trap configuration by SET/DEL on CONFIG_DB and vaidating the configuration by GET on ASIC_DB. These test cases will be extended to also verify the oper_status field in STATE_DB.
286+
* **Trap hw_status verification:** Existing test cases currently verify trap configuration by SET/DEL on CONFIG_DB and vaidating the configuration by GET on ASIC_DB. These test cases will be extended to also verify the hw_status field in STATE_DB.
286287
* **STATE_DB capability table verification:** New test cases will be added to verify the COPP_TRAP_CAPABILITY_TABLE table in STATE_DB. Test case will perform GET operation and verify trap_id_list field in the table is not empty.
287288

288289
#### 12.1.2. CLI UT Test Cases
@@ -295,4 +296,4 @@ No warmboot and fastboot impact is expected for this feature.
295296

296297
An existing test case in the sonic-mgmt PTF framework tests VLAN subnet route traffic policing under the default CoPP configuration.
297298

298-
A new test case will be introduced to verify the neighbor miss trap configuration with its default settings in copp_cfg.json using VLAN subnet route traffic. This test case will also update/empty/NULL configuration for neighbor miss in CONFIG_DB to override the default settings and verify the operational status of neighbor miss in the CLI output accordingly.
299+
A new test case will be introduced to verify the neighbor miss trap configuration with its default settings in copp_cfg.json using VLAN subnet route traffic. This test case will also update/empty/NULL configuration for neighbor miss in CONFIG_DB to override the default settings and verify the operational status of neighbor miss in the CLI output accordingly.

0 commit comments

Comments
 (0)