Skip to content

fix: bamcoverage without effective genome size #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions bio/deeptools/bamcoverage/test/Snakefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,15 @@ rule test_deeptools_bamcoverage_default_eff_len:
"logs/coverage_efault_eff_len.log",
wrapper:
"master/bio/deeptools/bamcoverage"


rule test_deeptools_bamcoverage_no_params:
input:
bam="a.sorted.bam",
bai="a.sorted.bam.bai",
output:
"a.coverage_no_params.bw",
log:
"logs/coverage.log",
wrapper:
"master/bio/deeptools/bamcoverage"
2 changes: 1 addition & 1 deletion bio/deeptools/bamcoverage/wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
},
}

effective_genome_size = snakemake.params.get("effective_genome_size")
effective_genome_size = snakemake.params.get("effective_genome_size", "")
if not effective_genome_size:
genome = snakemake.params.get("genome")
read_length = snakemake.params.get("read_length")
Expand Down
15 changes: 15 additions & 0 deletions test.py
Original file line number Diff line number Diff line change
Expand Up @@ -2870,6 +2870,21 @@ def test_deeptools_bamcoverage_eff():
)


@skip_if_not_modified
def test_deeptools_bamcoverage_no_params():
run(
"bio/deeptools/bamcoverage",
[
"snakemake",
"--cores",
"1",
"a.coverage_no_params.bw",
"--use-conda",
"-F",
],
)


@skip_if_not_modified
def test_deeptools_alignmentsieve():
run(
Expand Down
Loading