Chisel Corner Fix #4756
Merged
Chisel Corner Fix #4756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port of: PentestSS13/Pentest#284
FalloutFalcon
approved these changes
Apr 29, 2025
Yeah, that's cool. I believe it's being TMd on Pentest right now. I have two more PRs I will push that are more experimental than all the other minor changes I've pushed. |
shiptest-server
pushed a commit
that referenced
this pull request
May 8, 2025
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
May 18, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Port of: PentestSS13/Pentest#284 Chisel corners got reset back to the original appearance when a shuttle moved. This PR fixes that, though it has nothing to do with the chisel itself. I have tested it over multiple trips and it appears to work fine. I have not tested it with ship rotation/docking, but it will likely work just fine. copyTurf() is problematic as I note in [a different PR](PentestSS13/Pentest#288). <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Took way too long to pin down. Makes ships pretty. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: fix: Chisel corners will now be preserved when the ship moves. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Port of: PentestSS13/Pentest#284
Chisel corners got reset back to the original appearance when a shuttle moved. This PR fixes that, though it has nothing to do with the chisel itself. I have tested it over multiple trips and it appears to work fine.
I have not tested it with ship rotation/docking, but it will likely work just fine. copyTurf() is problematic as I note in a different PR.
Why It's Good For The Game
Took way too long to pin down. Makes ships pretty.
Changelog
🆑
fix: Chisel corners will now be preserved when the ship moves.
/:cl: