Glass Floor Transparency Fix #288
Open
+89
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes and improves window floors and material floors made from glass (and possibly other stuff). Includes some refactoring of the transparency element and some other code changes to make everything else possible. This should also fix the 'ghost turfs' that sometimes sprang up on underlay turfs, but I can't really confirm it for sure without more extensive testing. copyTurf() is problematic and should be addressed in the future.
Fix, maybe.
Regex, what are you talking about? There was never a text2path there.
|
So this will have to really wait until after the other merges since you removed an instance of text2path... and we will need to let some dust settle down to determine the current number of uses as we might have nudged the number up with a cherrypick. |
|
text2path is contained within another proc that my changes link to. I can bring it back, it's just copypasta for no real reason. |
We'll see if it works.
Oops.
FslashN
added a commit
to FslashN/Shiptest-Test-Test-Test
that referenced
this pull request
Apr 29, 2025
Port of: PentestSS13/Pentest#288
github-merge-queue bot
pushed a commit
to shiptest-ss13/Shiptest
that referenced
this pull request
May 8, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Port of: PentestSS13/Pentest#284 Chisel corners got reset back to the original appearance when a shuttle moved. This PR fixes that, though it has nothing to do with the chisel itself. I have tested it over multiple trips and it appears to work fine. I have not tested it with ship rotation/docking, but it will likely work just fine. copyTurf() is problematic as I note in [a different PR](PentestSS13/Pentest#288). <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Took way too long to pin down. Makes ships pretty. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: fix: Chisel corners will now be preserved when the ship moves. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
github-merge-queue bot
pushed a commit
to shiptest-ss13/Shiptest
that referenced
this pull request
May 8, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Port of: PentestSS13/Pentest#284 Chisel corners got reset back to the original appearance when a shuttle moved. This PR fixes that, though it has nothing to do with the chisel itself. I have tested it over multiple trips and it appears to work fine. I have not tested it with ship rotation/docking, but it will likely work just fine. copyTurf() is problematic as I note in [a different PR](PentestSS13/Pentest#288). <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Took way too long to pin down. Makes ships pretty. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: fix: Chisel corners will now be preserved when the ship moves. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
May 18, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Port of: PentestSS13/Pentest#284 Chisel corners got reset back to the original appearance when a shuttle moved. This PR fixes that, though it has nothing to do with the chisel itself. I have tested it over multiple trips and it appears to work fine. I have not tested it with ship rotation/docking, but it will likely work just fine. copyTurf() is problematic as I note in [a different PR](PentestSS13/Pentest#288). <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Took way too long to pin down. Makes ships pretty. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: fix: Chisel corners will now be preserved when the ship moves. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
|
This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Did not realize this was never merged upstream... lets TM it as this and see if we can keep it anyway... |
This comment was marked as resolved.
This comment was marked as resolved.
Ossa88
requested changes
Jun 11, 2025
I hope.
|
Since shiptest denied... I will push for modularization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Addresses: #127
Fixes and improves glass floors and material floors made from glass (and possibly other stuff). Includes some refactoring of the transparency element and some other code changes to make everything else possible. This should also fix the 'ghost turfs' that sometimes sprang up on underlay turfs, but I can't really confirm it for sure without more testing.
copyTurf() is problematic and should be addressed in the future. For more information on why stuff wasn't working right, check my writeup in the linked issue. This method uses relevant baseturfs instead of the old ZTRAIT_BASETURF lookup, and I think it looks a lot better. The drawback is that transparent underlays cannot tile together.
Why It's Good For The Game
Untitled.mp4
Changelog
🆑
fix: Fixed glass floor underlaying incorrectly and some other 'ghost turf' issues.
refactor: Refactored and improved turf transparency.
/:cl: