Skip to content

increase test tolerance to reduce flakiness (backport #2212) #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 30, 2025

I'm increasing the tolerances in this tests. The Min can be increased a lot as a single loop will affect everyone and this depends on the load of the system. The same goes to the "Average"


This is an automatic backport of pull request #2212 done by Mergify.

(cherry picked from commit 74cb0f0)

# Conflicts:
#	controller_manager/test/test_controller_manager.cpp
@mergify mergify bot added the conflicts label Apr 30, 2025
Copy link
Contributor Author

mergify bot commented Apr 30, 2025

Cherry-pick of 74cb0f0 has failed:

On branch mergify/bp/humble/pr-2212
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 74cb0f0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/test/test_controller_manager.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@christophfroehlich christophfroehlich marked this pull request as draft April 30, 2025 19:42
@saikishor saikishor closed this Apr 30, 2025
@saikishor
Copy link
Member

This fix is not needed for humble branch

@saikishor saikishor deleted the mergify/bp/humble/pr-2212 branch April 30, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant