Skip to content

increase test tolerance to reduce flakiness #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

saikishor
Copy link
Member

I'm increasing the tolerances in this tests. The Min can be increased a lot as a single loop will affect everyone and this depends on the load of the system. The same goes to the "Average"

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (af0d776) to head (9019be8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2212      +/-   ##
==========================================
+ Coverage   89.08%   89.11%   +0.02%     
==========================================
  Files         139      139              
  Lines       16118    16124       +6     
  Branches     1389     1389              
==========================================
+ Hits        14359    14369      +10     
+ Misses       1228     1224       -4     
  Partials      531      531              
Flag Coverage Δ
unittests 89.11% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ontroller_manager/test/test_controller_manager.cpp 95.80% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 74cb0f0 into ros-controls:master Apr 30, 2025
22 of 24 checks passed
@christophfroehlich christophfroehlich deleted the handle/flaky/async_controller_update_rate_tests branch April 30, 2025 19:36
@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble. label Apr 30, 2025
mergify bot pushed a commit that referenced this pull request Apr 30, 2025
(cherry picked from commit 74cb0f0)

# Conflicts:
#	controller_manager/test/test_controller_manager.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test per_controller_equal_and_higher_update_rate is flaky
2 participants