gh-94808: add tests covering PySequence_[InPlace_]Repeat
#99196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge conflicts are resolved, @serhiy-storchaka would you mind taking a look? :) |
skirpichev
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Looks good, except for few pep7 nitpicks.
On another hand, I'm not sure if this is a right approach to test abstract interfaces. Another example is PyNumber_* API (#111996). Maybe we should use special, dedicated just for tests types, that have required magic methods, instead of using core types?
| sequence_inplace_repeat(PyObject* self, PyObject *args) | ||
| { | ||
| PyObject *sequence; | ||
| Py_ssize_t count; |
There was a problem hiding this comment.
PEP 7: blank line after local variable declarations;)
| sequence_repeat(PyObject* self, PyObject *args) | ||
| { | ||
| PyObject *sequence; | ||
| Py_ssize_t count; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things I've skipped:
NULLchecks forPyLongallocation andNULLcheck forself. Cannot be reproduced from pythonsq_repeatandsq_inplace_repeat, I expect them to be covered in*and*=operatorsCoverage view before:
