merge latest prebid from master into branch #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create advenueBidAdapter.js * Create advenueBidAdapter.md * Update pbjs_example_gpt.html Add advenue integration example * Advenue test Added test for advenue adapter * changes made * edit * edit * Syntax error corrected * Remove grunt, changed ajv version to 6.2.2 * Edit * Update package-lock.json * removed response validation * removed unused variables * Removed deprecated method * Package-lock.json deleted * https://github.com/devadvenue/Prebid.js.git deleted * del * Add package-lock.json from main repository * Delete package-lock.json * Only pushing original file resolves merge conflict * Update advenueBidAdapter.js Changed URL, used BidderRequest object * Update advenueBidAdapter_spec.js * Update package-lock.json * Update advenueBidAdapter_spec.js
…id#3470) * calling for currency file even when default rates are specified * fixed broken unit tests * added unit test to check that currency file is still requested even when default rates are set
* LiveYield Analytics Adapter * tests corrections * fixed getPlacementOrAdUnitCode function * corrections * paths fixed * adaptermanager import fixed * manager corrections
* Changing to requestId in order to align with prebid cores mapping of bidId to responseId * Rubi Bid Adapter: Do not pass non-array FPD to Frank Video * Updating based on review + tests
* Support Multi-Format Ads - Banner & Video * Updated gdpr default value to false, updated test placementId in rhythmoneBidAdapter.md file * Version updated
* remove old dependencies and solve some peer dependencies * resolve package lock conflict * add coveralls dependency
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (#2) * ET-1850: Fixing prebid#866 * Minor fix * Adding mandatory parameters to Bid * PulsePoint crid fix
* add description to RD module * adding some more comments to private functions
* 3413-Insert Iframes for user sync in body * Append Iframe as the last child * Add unit test for insertElement * utls insert element at the top by default * add unit tests for utls insert element * Insert iframe as html last child * revert package.lock changes * Override keywords in setTargetingForAst * Add resetPresetTargetingAST for setTargetingForAst
…rebid#3476) * Update ReadPeak adapter * Replace $$PREBID_GLOBAL$$.version with $prebid.version$ * Fix test * Use utils.getTopWindowReferrer() instead of custom function * Fix device type and currency outgoing request of ReadPeak Bid Adapter * Update tests to check for language and currency for ReadPeakBidAdapter
* initial orbidder version in personal github repo * use adUnits from orbidder_example.html * replace obsolete functions * forgot to commit the test * check if bidderRequest object is available * try to fix weird safari/ie issue * ebayK: add more params * update orbidderBidAdapter.md * use spec.<function> instead of this.<function> for consistency reasons
* Add bidfloor to params to allow dynamic bid floor CPM * polyfill Number.isFinite for IE11/Safari 8 * ADSS-538 Revert changes to package-lock.json
* added fun-hooks adapter * use npm fun-hooks * some test fixes * have currency module tests clean up hooks after it runs * have config.resetConfig notify listeners that they've been reset * update chai to latest and fix tests * add deprecation warning for createHook * remove old hooks api and pre1api module for 2.0 * remove callback fn from arguments in consentManagement hook * added ready functionality for hooks * update package.json and lock
* 3413-Insert Iframes for user sync in body * Append Iframe as the last child * Add unit test for insertElement * utls insert element at the top by default * add unit tests for utls insert element * Insert iframe as html last child * revert package.lock changes * Override keywords in setTargetingForAst * Add resetPresetTargetingAST for setTargetingForAst * get bidresponses form last auction Id * ignore getbidresponses unit test * Add unit test for getBidResponses * fix typo * Add unit test for getBidResponses * code review changes * add minor check
…ature to work for video ad units (prebid#3483)
* Add support for multiple media types. Add test coverage. * Add support for multiple media types. Add test coverage. * Modify multi-format ads handler. Modify tests.
Added "len" param to show we support it.
* Support new aniview bid adapter * Support new aniview bid adapter * Support new aniview bid adapter * Support new aniview bid adapter * Fix Consent parameters
* #feature (modules/decenteradsBidAdapter.js, modules/decenteradsBidAdapter.md,test/spec/modules/decenteradsBidAdapter_spec.js) added DecenterAds adapter * #fix (modules/decenteradsBidAdapter.js) minor fixes
…Response event and error was thrown. This issue was fixed (prebid#3546)
IAS is no passing their key when the currency module is used. Indeed the letter case is important as the module will look for "USD" not "usd" and then return no bid
* added support for outstream in sonobi adapter * added remote url for outstream renderer * renamed remote url for sbi renderer outstream * outstream renderer is not loaded by default * remove unsed import * getting outstream size from params.sizes * sizes is an array of arrays * added unit test for outstream bid response * mediaType is video if there is no mediaType context and sbi_ct is video * simplify if else conditions around video mediaTypes * fixed issue when calling Array.find in IE11 * fixed issue in IE11 and mac when using for of...
* Adding files associated with the trion adapter update to the newest prebid version(1.0). * Updating pull request with safer checks for user sync and general clean up/consistency of tests. * removing a call to bidder code for pull request review. also removing the test that requires it * there were some changes to the bid factory after our initial release that we didn't account for. Changing adapter to account for response body and required params. * Revert "there were some changes to the bid factory after our initial release that we didn't account for. Changing adapter to account for response body and required params." This reverts commit 324d157. * there were some changes to the bid factory after our initial release that we didn't account for. Changing adapter to account for response body and required params. * adding safety checks to Trion adapter
* bugfix for Firefox for some ads that use document.write * testing that the doc.open method is called..... * added a sinon.spy() for the doc.open method
* Added Grid Bid Adapter * remove priceType from TheMediaGrid Bid Adapter * Add video support in Grid Bid Adapter * Added test parameter for video slot * update Grid Bid Adapter to set size in response bid
* add adtelligent gdpr support * Fix test
* New Adapter VMG * anticipate absence of "buildRequests >> bidderRequest.refererInfo" in prebid_1_0
* add open8 adapter * slotkey and fix * add maintainer address * add bidwon * check field populated
* Add removeAllAdUnits to the API * revert package.loc * Update removeAdUnit and remove removeAllAdUnts * update var to let
* added setTargeting code for custom key-value pairs * v1.4.3 - refactored setTargeting code, includes support for pub common ID being passed inside ext.ozone object, refactored the ext.ozone object to carry any data objects defined in on-page bidder config * Update to setTargeting functionality per feedback from prebid.org. * switching from // to https:// to match unit test
* mgidAdapter * mgidAdapter description * mgidAdapter test fixes * mgidAdapter test fixes * mgidAdapter test fixes * mgidAdapter test fixes * mgidAdapter test fixes * mgidAdapter test fixes * mgidAdapter test fixes * mgidAdapter test fixes * mgidAdapter test fixes * mgidAdapter gdpr + ver * test params * test params changed * revert * revert
* Add trustx adapter and tests for it * update integration example * Update trustx adapter * Post-review fixes of Trustx adapter * Code improvement for trustx adapter: changed default price type from gross to net * Update TrustX adapter to support the 1.0 version * Make requested changes for TrustX adapter * Updated markdown file for TrustX adapter * Fix TrustX adapter and spec file * Update TrustX adapter: r parameter was added to ad request as cache buster * Add support of gdpr to Trustx Bid Adapter * Add wtimeout to ad request params for TrustX Bid Adapter * TrustX Bid Adapter: remove last ampersand in the ad request * Update TrustX Bid Adapter to support identical uids in parameters * Update TrustX Bid Adapter to ignore bids that sizes do not match the size of the request
* theAdx BidAdapter module and test spec added * requested changes from reviewer
* Add cleanmedianet bidder adapter * Use passed in url & utils url parsing function
* LiveYield Analytics Adapter * tests corrections * fixed getPlacementOrAdUnitCode function * DFP support * SRTA-399 WIP * DFP handler corrections, tests added * test added * docs added * SRTA-399 LiveYield DfP support SRTA-399 Minor reformats impression value fixed changed path to rta params corrections resolveSlot fixed postprocess() param fixed docs update imprVal(), imprPartner() impl added SRTA-399 Docs, no console.log * SRTA-410 Default implementations based on hb_adid * SRTA-399 chai usage fix
merge latest prebid into fork master
pm-manasi-moghe
pushed a commit
that referenced
this pull request
Apr 8, 2019
* Rvr 2369 Refactor events handling (#9) * RVR-2177 - Refactor events handling * RVR-2087 - Inject pbjsGlobalVariable into rivraddon * RVR-2087 - update adapterManager dependency * RVR-2087 - Add ADD_AD_UNITS to Prebid.JS trackable events * RVR-2369 - Update package-lock.json * Rvr 2369 prevent duplicate events (#10) ## Type of change - [x] Refactoring (no functional changes, no api changes) ## Description of change Refactor rivrAnalyticsAdapter.js events handling. ## History * RVR-2087 - update adapterManager dependency * RVR-2369 - Update package-lock.json * RVR-2369 - Revert changes in main Analytics adapter It will be handled in a separate PR * RVR-2369 - Use relative import paths Needed for prebid#3435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information