Skip to content

Sonobi - Outstream Support #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 14, 2019

Conversation

JonGoSonobi
Copy link
Contributor

@JonGoSonobi JonGoSonobi commented Feb 13, 2019

Type of change

  • Feature

Description of change

Added support for outstream in sonobi adapter

  • test parameters for validating outstream bids
var adUnits = [{
            code: 'div-gpt-ad-1460505748561-0',
            sizes: [[640, 480]],
            mediaTypes: {
                video: {
                    context: 'outstream'
                }
            },
            bids: [
                {
                    bidder: 'sonobi',
                    params: {
                        placement_id: '92e95368e86639dbd86d',
                        sizes: [[640,480]]
                    }
                }
            ]
        }];

@jsnellbaker jsnellbaker self-requested a review February 13, 2019 20:26
@jsnellbaker jsnellbaker self-assigned this Feb 13, 2019
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JonGoSonobi

I was trying to test the changes with the params that were provided in the description, however it seems like the server wasn't returning a value in the slots object.

Below is a copy of the entire response object:

{"slots":{"27049d9fd32481":{}},"sbi_dc":"iad-2-","sbi_px":[{"code":"","url":"//sync.go.sonobi.com/uc.html?pubid=06496f4078","type":"iframe"}]}

Below is a copy of the request URL (if needed):

https://apex.go.sonobi.com/trinity.json?key_maker=%7B%2227049d9fd32481%22%3A%2292e95368e86639dbd86d%7C640x480%22%7D&ref=http%3A%2F%2Ftest.localhost%3A9999%2FintegrationExamples%2Fgpt%2Foutstream.html%3Fpbjs_debug%3Dtrue&s=c6e79107-5365-4538-baff-0b6d5c1562ac&pv=b70e9a6b-d9c9-4277-b2c4-ff22e2e1fd57&vp=desktop&lib_name=prebid&lib_v=2.3.0-pre&us=5&hfa=PRE-b662097d-601d-42d0-962f-623abd0965a8&

Could you take a look to see what may be amiss?

@JonGoSonobi
Copy link
Contributor Author

@jsnellbaker Sorry forgot this detail for the test params to work. You need to go to this page http://tester.go.sonobi.com/cookie.html it will set a cookie on you that will enable a test mode for your browser for 30 mins, forcing fake test bids to always be returned from our request bids endpoint.

@jsnellbaker
Copy link
Collaborator

Thanks for extra info. I setup the cookie and the bid came back successfully. LGTM

@jsnellbaker jsnellbaker merged commit 520e0a8 into prebid:master Feb 14, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
* added support for outstream in sonobi adapter

* added remote url for outstream renderer

* renamed remote url for sbi renderer outstream

* outstream renderer is not loaded by default

* remove unsed import

* getting outstream size from params.sizes

* sizes is an array of arrays

* added unit test for outstream bid response

* mediaType is video if there is no mediaType context and sbi_ct is video

* simplify if else conditions around video mediaTypes

* fixed issue when calling Array.find in IE11

* fixed issue in IE11 and mac when using for of...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants