-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Sonobi - Outstream Support #3559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonobi - Outstream Support #3559
Conversation
…-9-sonobi-outstream-renderer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JonGoSonobi
I was trying to test the changes with the params that were provided in the description, however it seems like the server wasn't returning a value in the slots
object.
Below is a copy of the entire response object:
{"slots":{"27049d9fd32481":{}},"sbi_dc":"iad-2-","sbi_px":[{"code":"","url":"//sync.go.sonobi.com/uc.html?pubid=06496f4078","type":"iframe"}]}
Below is a copy of the request URL (if needed):
https://apex.go.sonobi.com/trinity.json?key_maker=%7B%2227049d9fd32481%22%3A%2292e95368e86639dbd86d%7C640x480%22%7D&ref=http%3A%2F%2Ftest.localhost%3A9999%2FintegrationExamples%2Fgpt%2Foutstream.html%3Fpbjs_debug%3Dtrue&s=c6e79107-5365-4538-baff-0b6d5c1562ac&pv=b70e9a6b-d9c9-4277-b2c4-ff22e2e1fd57&vp=desktop&lib_name=prebid&lib_v=2.3.0-pre&us=5&hfa=PRE-b662097d-601d-42d0-962f-623abd0965a8&
Could you take a look to see what may be amiss?
@jsnellbaker Sorry forgot this detail for the test params to work. You need to go to this page http://tester.go.sonobi.com/cookie.html it will set a cookie on you that will enable a test mode for your browser for 30 mins, forcing fake test bids to always be returned from our request bids endpoint. |
Thanks for extra info. I setup the cookie and the bid came back successfully. LGTM |
* added support for outstream in sonobi adapter * added remote url for outstream renderer * renamed remote url for sbi renderer outstream * outstream renderer is not loaded by default * remove unsed import * getting outstream size from params.sizes * sizes is an array of arrays * added unit test for outstream bid response * mediaType is video if there is no mediaType context and sbi_ct is video * simplify if else conditions around video mediaTypes * fixed issue when calling Array.find in IE11 * fixed issue in IE11 and mac when using for of...
Type of change
Description of change
Added support for outstream in sonobi adapter