-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New bid adapter for aniview #3522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs PR prebid/prebid.github.io#1135 |
modules/aniviewBidAdapter.js
Outdated
|
||
if (bidderRequest && bidderRequest.gdprConsent) { | ||
if (bidderRequest.gdprConsent.gdprApplies) { | ||
AV_GDPR = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GDPR data is being stored on the window object, is this intentional?
Here are the resulting window properties created from lines 100 and 101:
window.AV_GDPR = 1
window.AV_CONSENT = "..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question regarding the creation of global
variables for GDPR
and GDPR_CONSENT
, but the rest of the code looks good. Bids were returned with the sample data provided in the markdown file.
@idettman thanks for your comment, Consent parameters fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
www.aniview.com
Please approve new bid adapter for aniview
Type of change
Description of change
New bid adapter for aniview
Be sure to test the integration with your adserver using the Hello World sample page.
contact email of the adapter’s maintainer
[x ] official adapter submission
[email protected]
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/
Other information