Skip to content

New bid adapter for aniview #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 12, 2019
Merged

New bid adapter for aniview #3522

merged 5 commits into from
Feb 12, 2019

Conversation

itaynave
Copy link
Contributor

@itaynave itaynave commented Feb 6, 2019

www.aniview.com
Please approve new bid adapter for aniview

Type of change

  • [ x] New bidder adapter
  • Done

Description of change

New bid adapter for aniview

  • test parameters for validating bids
{
  bidder: 'aniview',
  params: {
            AV_PUBLISHERID: '55b78633181f4603178b4568',
            AV_CHANNELID: '55b7904d181f46410f8b4568'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

Other information

@bretg
Copy link
Collaborator

bretg commented Feb 6, 2019

docs PR prebid/prebid.github.io#1135


if (bidderRequest && bidderRequest.gdprConsent) {
if (bidderRequest.gdprConsent.gdprApplies) {
AV_GDPR = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GDPR data is being stored on the window object, is this intentional?
Here are the resulting window properties created from lines 100 and 101:

window.AV_GDPR = 1
window.AV_CONSENT = "..."

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question regarding the creation of global variables for GDPR and GDPR_CONSENT, but the rest of the code looks good. Bids were returned with the sample data provided in the markdown file.

@itaynave
Copy link
Contributor Author

itaynave commented Feb 7, 2019

@idettman thanks for your comment, Consent parameters fixed

@bretg bretg removed the question label Feb 7, 2019
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit 3fa81fc into prebid:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants