Add 'title' to distinguish multiple projects in actions-plan-preview #5905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
…review/distinguish-B_args Signed-off-by: t-kikuc <[email protected]>
t-kikuc
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5905 +/- ##
=======================================
Coverage 27.89% 27.90%
=======================================
Files 519 519
Lines 55923 55936 +13
=======================================
+ Hits 15600 15609 +9
- Misses 39125 39129 +4
Partials 1198 1198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ponkio-o
reviewed
May 30, 2025
| got, err := parseGitHubEvent(context.Background(), tc.prService, tc.eventName, tc.payload, tc.argPRNum) | ||
| assert.Equal(t, tc.expected, got) | ||
| assert.Equal(t, tc.expectedErr, err) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestFilterLatestPlanPreviewComment(t *testing.T) { |
There was a problem hiding this comment.
[IMO] I think it's better to add a test case for a multibyte string.
There was a problem hiding this comment.
Thank you!
I added: 9bb4a1f
Signed-off-by: t-kikuc <[email protected]>
ponkio-o
approved these changes
Jun 2, 2025
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
…5905) * add title to args Signed-off-by: t-kikuc <[email protected]> * Add the title to filter latest comments Signed-off-by: t-kikuc <[email protected]> * Use hash Signed-off-by: t-kikuc <[email protected]> * Fix tests Signed-off-by: t-kikuc <[email protected]> * add multibyte test Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
Warashi
added a commit
that referenced
this pull request
Jun 2, 2025
* Fix lint errors (#5897) * Fix import grouping by make lint/go FIX=true Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Fix linter errors by make lint/go FIX=true Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Rewrite long if-else to switch Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Remove unnecessary zero-value initialization Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Remove unnecessary string conversion Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Fix to correctly call deferred functions log.Fatalf calls os.Exit(1) and deferred functions are not called. This commit changes the _main function to return an integer and call os.Exit from main. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Fix lint errors log.Fatal calls os.Exit, so the deferred functions are not called. This commit changes the _main function to return an integer and call os.Exit from main. This is a workaround to fix the lint errors. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Fix lint errors Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Initialize the slice with the correct capacity Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Change return type of doComment to int Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Add 'title' to distinguish multiple projects in actions-plan-preview (#5905) * add title to args Signed-off-by: t-kikuc <[email protected]> * Add the title to filter latest comments Signed-off-by: t-kikuc <[email protected]> * Use hash Signed-off-by: t-kikuc <[email protected]> * Fix tests Signed-off-by: t-kikuc <[email protected]> * add multibyte test Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Revert "Do treeless clone for git clone to improve performance (#5722)" (#5908) This reverts commit 7e74937. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Cut release v0.52.1 (#5909) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Warashi <[email protected]> Signed-off-by: pipecd-bot <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: t-kikuc <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]> Co-authored-by: Tetsuya KIKUCHI <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Warashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
titleinputtitlein result headertitleAfter this PR is merged, I will update pipe-cd/actions-plan-preview#21 and we'll release.
Example
planpreview config:
Why we need it:
as described in #5899
Which issue(s) this PR fixes:
Fixes #5899
Does this PR introduce a user-facing change?: