Skip to content

Enhance the result of PlanPreview Action to distinguish multiple projects #5899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
t-kikuc opened this issue May 29, 2025 · 1 comment · Fixed by #5905
Closed

Enhance the result of PlanPreview Action to distinguish multiple projects #5899

t-kikuc opened this issue May 29, 2025 · 1 comment · Fixed by #5905
Assignees
Labels
kind/enhancement New feature or request

Comments

@t-kikuc
Copy link
Member

t-kikuc commented May 29, 2025

What would you like to be added:

  1. Distinguish results by their Project clearly
  2. Avoid minimizing the result of other Projects

Why is this needed:

When a user requests PlanPreview from one repository to multiple PipeCD Projects,

  1. users cannot tell which Project the result comes from. That is inconvenient.
  2. the earlier result will be minimized due to this logic of <!-- pipecd-plan-preview-->:
    // Expect comments to be sorted in ascending order by created_at
    func filterLatestPlanPreviewComment(comments []issueCommentQuery) *issueCommentQuery {
    const planPreviewCommentStart = "<!-- pipecd-plan-preview-->"
    for i := range comments {
    comment := comments[len(comments)-i-1]
    if strings.HasPrefix(string(comment.Body), planPreviewCommentStart) {
    return &comment
    }
    }
    return nil
    }
@t-kikuc t-kikuc added the kind/enhancement New feature or request label May 29, 2025
@t-kikuc
Copy link
Member Author

t-kikuc commented May 29, 2025

The same as this one:
#5898 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant