-
Notifications
You must be signed in to change notification settings - Fork 182
Revert "Do treeless clone for git clone to improve performance" #5908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 7e74937. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
3b0e76f
to
3fff308
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5908 +/- ##
==========================================
- Coverage 27.89% 27.88% -0.02%
==========================================
Files 519 519
Lines 55926 55932 +6
==========================================
- Hits 15603 15596 -7
- Misses 39125 39136 +11
- Partials 1198 1200 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
…" (#5908) This reverts commit 7e74937. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
* Fix lint errors (#5897) * Fix import grouping by make lint/go FIX=true Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Fix linter errors by make lint/go FIX=true Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Rewrite long if-else to switch Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Remove unnecessary zero-value initialization Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Remove unnecessary string conversion Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Fix to correctly call deferred functions log.Fatalf calls os.Exit(1) and deferred functions are not called. This commit changes the _main function to return an integer and call os.Exit from main. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Fix lint errors log.Fatal calls os.Exit, so the deferred functions are not called. This commit changes the _main function to return an integer and call os.Exit from main. This is a workaround to fix the lint errors. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Fix lint errors Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Initialize the slice with the correct capacity Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Change return type of doComment to int Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Add 'title' to distinguish multiple projects in actions-plan-preview (#5905) * add title to args Signed-off-by: t-kikuc <[email protected]> * Add the title to filter latest comments Signed-off-by: t-kikuc <[email protected]> * Use hash Signed-off-by: t-kikuc <[email protected]> * Fix tests Signed-off-by: t-kikuc <[email protected]> * add multibyte test Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Revert "Do treeless clone for git clone to improve performance (#5722)" (#5908) This reverts commit 7e74937. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Cut release v0.52.1 (#5909) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Warashi <[email protected]> Signed-off-by: pipecd-bot <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: t-kikuc <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]> Co-authored-by: Tetsuya KIKUCHI <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Warashi <[email protected]>
Reverts #5722
The eventwatcher calls
repo.CopyToModify
every time, regardless of whether the event is registered.This causes git clone from remote, e.g., GitHub, every time and costs network I/O.
The solution might be to call it
CopyToModify
only when the modification occurs.For now, I revert the treeless clone because I don't have enough time to do so.
pipecd/pkg/app/piped/eventwatcher/eventwatcher.go
Lines 322 to 336 in 24a573d