add labels to application delete dialog box #5727

atpugtihsrah · 2025-04-07T06:11:56Z

What this PR does: Adds application labels to the application delete box.

Before:

After:

Why we need it: Issue #5713 would like to add labels to the application delete box.

Which issue(s) this PR fixes: #5713

Fixes #5713

Does this PR introduce a user-facing change?: Yes

How are users affected by this change: All
Is this breaking change: No
How to migrate (if breaking change): Not Applicable

atpugtihsrah · 2025-04-07T06:13:07Z

@khanhtc1202 Please review :)

khanhtc1202 · 2025-04-07T08:24:36Z

cc @hongky-1994 plz check 👀

hongky-1994

@atpugtihsrah Thank you for the great work!
The behavior looks good to me 👍 I left a comment with a suggestion to improve readability."

web/src/components/applications-page/application-list/delete-application-dialog/index.tsx

atpugtihsrah · 2025-04-08T16:43:26Z

@hongky-1994 Many thanks for the review 🙏 I have made the changes based on your suggestions. Please review again :)

Signed-off-by: Harshit Gupta <[email protected]>

…ved readability Signed-off-by: Harshit Gupta <[email protected]>

hongky-1994

LGTM 👍

atpugtihsrah · 2025-04-09T04:45:54Z

@khanhtc1202 Also need your approval to merge :)

khanhtc1202

Thank you 👍

atpugtihsrah · 2025-04-09T05:25:30Z

@khanhtc1202 You will also have to merge because I am not authorized to push to the master branch :)

atpugtihsrah · 2025-04-09T05:36:21Z

@khanhtc1202 Many many thanks for letting me contribute and creating a very welcoming environment for me ❤️

khanhtc1202 · 2025-04-09T05:39:24Z

@atpugtihsrah thanks for interest and contribute 😁
Please be around or join our public meeting (information on Slack or README) sometime for more contribution/collaboration chances. Thank you!

atpugtihsrah · 2025-04-09T05:45:09Z

@khanhtc1202 ❤️ Sure I would love to join, let me check when is the next public meeting. I will also request to start on a new task soon :)

Signed-off-by: pipecd-bot <[email protected]>

@ren510dev

* fix: upgrade react-router-dom from 6.29.0 to 6.30.0 (#5686) Snyk has created this PR to upgrade react-router-dom from 6.29.0 to 6.30.0. See this package in yarn: react-router-dom See this project in Snyk: https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: t-kikuc <[email protected]> Co-authored-by: snyk-bot <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Revert "Temporary disable v1 add application form on UI (#5694)" (#5696) This reverts commit dca04f9. Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Use nodejs 20 as web image builder (#5726) Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * add labels to application delete dialog box (#5727) Signed-off-by: pipecd-bot <[email protected]> * fix: regex based tag replacement scheme (#5730) * fix: regex based tag replacement scheme Signed-off-by: GotoRen <[email protected]> * fix: nits comment Signed-off-by: GotoRen <[email protected]> * fix: copy changes into main implementation Signed-off-by: GotoRen <[email protected]> --------- Signed-off-by: GotoRen <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Modify pvc name attached to deployment (#5734) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * fix piped name suggestion when adding new application (#5735) Signed-off-by: Dave Canton <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Disable register app for pipedv1 form (#5739) Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Bump golang.org/x/net from 0.36.0 to 0.38.0 in /tool/actions-gh-release (#5741) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0. - [Commits](golang/net@v0.36.0...v0.38.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: pipecd-bot <[email protected]> * Bump http-proxy-middleware from 2.0.7 to 2.0.9 in /web (#5742) Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.7 to 2.0.9. - [Release notes](https://github.com/chimurai/http-proxy-middleware/releases) - [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.9/CHANGELOG.md) - [Commits](chimurai/http-proxy-middleware@v2.0.7...v2.0.9) --- updated-dependencies: - dependency-name: http-proxy-middleware dependency-version: 2.0.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: pipecd-bot <[email protected]> * Update go-jwt to version 5.2.2 (#5743) * Update go-jwt to version 5.2.2 Signed-off-by: khanhtc1202 <[email protected]> * Use the previous signing method Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Bump golang.org/x/net in /tool/actions-plan-preview (#5745) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0. - [Commits](golang/net@v0.36.0...v0.38.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: pipecd-bot <[email protected]> * Bump golang.org/x/net from 0.36.0 to 0.38.0 (#5746) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0. - [Commits](golang/net@v0.36.0...v0.38.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: pipecd-bot <[email protected]> * Cut release v0.51.2 (#5753) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: GotoRen <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: Dave Canton <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Chris Aniszczyk <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]> Co-authored-by: Harshit Gupta <[email protected]> Co-authored-by: Ren Goto (@ren510dev) <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Dave <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

atpugtihsrah requested review from khanhtc1202, ffjlabo, t-kikuc and Warashi as code owners April 7, 2025 06:11

github-actions bot added the area/web label Apr 7, 2025

atpugtihsrah force-pushed the add-application-labels-32ceg3pm10 branch 2 times, most recently from 3863014 to d214bac Compare April 7, 2025 06:22

hongky-1994 reviewed Apr 8, 2025

View reviewed changes

web/src/components/applications-page/application-list/delete-application-dialog/index.tsx Outdated Show resolved Hide resolved

web/src/components/applications-page/application-list/delete-application-dialog/index.tsx Outdated Show resolved Hide resolved

atpugtihsrah force-pushed the add-application-labels-32ceg3pm10 branch from 962c216 to 6f126fc Compare April 8, 2025 16:44

atpugtihsrah added 2 commits April 8, 2025 18:45

add labels to application delete dialog box

fe593f1

Signed-off-by: Harshit Gupta <[email protected]>

Add Mui Box instead of inline style and extract into method for impro…

16178aa

…ved readability Signed-off-by: Harshit Gupta <[email protected]>

atpugtihsrah force-pushed the add-application-labels-32ceg3pm10 branch from 6f126fc to 16178aa Compare April 8, 2025 16:45

hongky-1994 approved these changes Apr 9, 2025

View reviewed changes

khanhtc1202 approved these changes Apr 9, 2025

View reviewed changes

khanhtc1202 merged commit 2fdc739 into pipe-cd:master Apr 9, 2025
15 checks passed

khanhtc1202 added cherry-pick v0.51.2 labels Apr 18, 2025

github-actions bot pushed a commit that referenced this pull request Apr 18, 2025

add labels to application delete dialog box (#5727)

d469c5b

Signed-off-by: pipecd-bot <[email protected]>

github-actions bot mentioned this pull request Apr 18, 2025

Cherry-pick to release-v0.51.x #5757

Merged

khanhtc1202 mentioned this pull request Apr 22, 2025

show application's labels on the delete application confirmation box #5713

Closed

github-actions bot mentioned this pull request May 15, 2025

Release v0.51.3 #5821

Merged

github-actions bot mentioned this pull request May 28, 2025

[bot] Release v0.52.0 #5888

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add labels to application delete dialog box #5727

add labels to application delete dialog box #5727

Uh oh!

atpugtihsrah commented Apr 7, 2025 •

edited

Loading

Uh oh!

atpugtihsrah commented Apr 7, 2025

Uh oh!

khanhtc1202 commented Apr 7, 2025

Uh oh!

hongky-1994 left a comment

Uh oh!

Uh oh!

Uh oh!

atpugtihsrah commented Apr 8, 2025

Uh oh!

hongky-1994 left a comment

Uh oh!

atpugtihsrah commented Apr 9, 2025

Uh oh!

khanhtc1202 left a comment

Uh oh!

atpugtihsrah commented Apr 9, 2025

Uh oh!

Uh oh!

atpugtihsrah commented Apr 9, 2025

Uh oh!

khanhtc1202 commented Apr 9, 2025

Uh oh!

atpugtihsrah commented Apr 9, 2025

Uh oh!

Uh oh!

add labels to application delete dialog box #5727

add labels to application delete dialog box #5727

Uh oh!

Conversation

atpugtihsrah commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

atpugtihsrah commented Apr 7, 2025

Uh oh!

khanhtc1202 commented Apr 7, 2025

Uh oh!

hongky-1994 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

atpugtihsrah commented Apr 8, 2025

Uh oh!

hongky-1994 left a comment

Choose a reason for hiding this comment

Uh oh!

atpugtihsrah commented Apr 9, 2025

Uh oh!

khanhtc1202 left a comment

Choose a reason for hiding this comment

Uh oh!

atpugtihsrah commented Apr 9, 2025

Uh oh!

Uh oh!

atpugtihsrah commented Apr 9, 2025

Uh oh!

khanhtc1202 commented Apr 9, 2025

Uh oh!

atpugtihsrah commented Apr 9, 2025

Uh oh!

Uh oh!

atpugtihsrah commented Apr 7, 2025 •

edited

Loading