Skip to content

Use nodejs 20 as web image builder #5726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Conversation

Warashi
Copy link
Member

@Warashi Warashi commented Apr 7, 2025

What this PR does:

as title

Why we need it:

We specify that the web requires Node JS 20 or later, but we use Node JS 18 for building container images.
This comes from #5423, a pull request to improve CI stability.
We changed the build platform of the web asset builder in #5578, so we can now use NodeJS 20 for the web builder.
ref; #5578 (comment)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.94%. Comparing base (a306b3f) to head (f6f29b8).
Report is 137 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5726   +/-   ##
=======================================
  Coverage   26.94%   26.94%           
=======================================
  Files         501      501           
  Lines       53027    53027           
=======================================
  Hits        14290    14290           
  Misses      37670    37670           
  Partials     1067     1067           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi Warashi marked this pull request as ready for review April 7, 2025 01:01
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go 👍

@khanhtc1202 khanhtc1202 merged commit 5418f97 into master Apr 7, 2025
18 checks passed
@khanhtc1202 khanhtc1202 deleted the web-image-nodejs-20 branch April 7, 2025 08:31
@ffjlabo ffjlabo moved this to Done in v0.51.2 Apr 11, 2025
@ffjlabo ffjlabo added this to v0.51.2 Apr 11, 2025
github-actions bot pushed a commit that referenced this pull request Apr 18, 2025
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
khanhtc1202 added a commit that referenced this pull request Apr 18, 2025
* fix: upgrade react-router-dom from 6.29.0 to 6.30.0 (#5686)

Snyk has created this PR to upgrade react-router-dom from 6.29.0 to 6.30.0.

See this package in yarn:
react-router-dom

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

* Revert "Temporary disable v1 add application form on UI (#5694)" (#5696)

This reverts commit dca04f9.

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

* Use nodejs 20 as web image builder (#5726)

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

* add labels to application delete dialog box (#5727)

Signed-off-by: pipecd-bot <[email protected]>

* fix: regex based tag replacement scheme (#5730)

* fix: regex based tag replacement scheme

Signed-off-by: GotoRen <[email protected]>

* fix: nits comment

Signed-off-by: GotoRen <[email protected]>

* fix: copy changes into main implementation

Signed-off-by: GotoRen <[email protected]>

---------

Signed-off-by: GotoRen <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

* Modify pvc name attached to deployment (#5734)

Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

* fix piped name suggestion when adding new application (#5735)

Signed-off-by: Dave Canton <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

* Disable register app for pipedv1 form (#5739)

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

* Bump golang.org/x/net from 0.36.0 to 0.38.0 in /tool/actions-gh-release (#5741)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0.
- [Commits](golang/net@v0.36.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: pipecd-bot <[email protected]>

* Bump http-proxy-middleware from 2.0.7 to 2.0.9 in /web (#5742)

Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.7 to 2.0.9.
- [Release notes](https://github.com/chimurai/http-proxy-middleware/releases)
- [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.9/CHANGELOG.md)
- [Commits](chimurai/http-proxy-middleware@v2.0.7...v2.0.9)

---
updated-dependencies:
- dependency-name: http-proxy-middleware
  dependency-version: 2.0.9
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: pipecd-bot <[email protected]>

* Update go-jwt to version 5.2.2 (#5743)

* Update go-jwt to version 5.2.2

Signed-off-by: khanhtc1202 <[email protected]>

* Use the previous signing method

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

* Bump golang.org/x/net in /tool/actions-plan-preview (#5745)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0.
- [Commits](golang/net@v0.36.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: pipecd-bot <[email protected]>

* Bump golang.org/x/net from 0.36.0 to 0.38.0 (#5746)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0.
- [Commits](golang/net@v0.36.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: pipecd-bot <[email protected]>

* Cut release v0.51.2 (#5753)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: khanhtc1202 <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: GotoRen <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Dave Canton <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Chris Aniszczyk <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]>
Co-authored-by: Harshit Gupta <[email protected]>
Co-authored-by: Ren Goto (@ren510dev) <[email protected]>
Co-authored-by: Yoshiki Fujikane <[email protected]>
Co-authored-by: Dave <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request May 15, 2025
@github-actions github-actions bot mentioned this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants