Skip to content

Commit 16178aa

Browse files
committed
Add Mui Box instead of inline style and extract into method for improved readability
Signed-off-by: Harshit Gupta <[email protected]>
1 parent fe593f1 commit 16178aa

File tree

1 file changed

+16
-15
lines changed
  • web/src/components/applications-page/application-list/delete-application-dialog

1 file changed

+16
-15
lines changed

web/src/components/applications-page/application-list/delete-application-dialog/index.tsx

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { Application, selectById } from "~/modules/applications";
22
import {
3+
Box,
34
Button,
45
CircularProgress,
56
Dialog,
@@ -87,6 +88,19 @@ export const DeleteApplicationDialog: FC<DeleteApplicationDialogProps> = memo(
8788
dispatch(clearDeletingApp());
8889
}, [dispatch]);
8990

91+
const renderLabels = useCallback(() => {
92+
if (!application?.labelsMap) return <Skeleton height={24} width={200} />;
93+
94+
if (application.labelsMap.length === 0) return "-";
95+
96+
return application.labelsMap.map(([key, value]) => (
97+
<Fragment key={key}>
98+
<span>{`${key}: ${value}`}</span>
99+
<br />
100+
</Fragment>
101+
));
102+
}, [application?.labelsMap]);
103+
90104
return (
91105
<Dialog
92106
open={Boolean(application)}
@@ -109,23 +123,10 @@ export const DeleteApplicationDialog: FC<DeleteApplicationDialogProps> = memo(
109123
<Skeleton height={24} width={200} />
110124
)}
111125
</Typography>
112-
<div style={{ height: 24 }} /> {/* Spacer */}
126+
<Box height={24} />
113127
<Typography variant="caption">Labels</Typography>
114128
<Typography variant="body1" className={classes.applicationLabels}>
115-
{application ? (
116-
application.labelsMap.length !== 0 ? (
117-
application.labelsMap.map(([key, value]) => (
118-
<Fragment key={key}>
119-
<span>{key + ": " + value}</span>
120-
<br />
121-
</Fragment>
122-
))
123-
) : (
124-
"-"
125-
)
126-
) : (
127-
<Skeleton height={24} width={200} />
128-
)}
129+
{renderLabels()}
129130
</Typography>
130131
</DialogContent>
131132
<DialogActions>

0 commit comments

Comments
 (0)