Merges main branch into v1 #1420
Conversation
Re-adds removed builder APIs and adds deprecation notice
Updates planner builder deprecation message
Adds a unit-test for excluding a column that is as a result of a new projection from a subquery.
More details:
```
PartiQL> SELECT tbl2.* EXCLUDE tbl2.dervidedColumn FROM (SELECT tbl1.*, tbl1.a.b + 2 AS dervidedColumn FROM <<{'a': {'b': 2}, 'foo': 'bar', 'foo2': 'bar2'}>> AS tbl1) AS tbl2;
==='
<<
{
'a': {
'b': 2
},
'foo': 'bar',
'foo2': 'bar2'
}
>>
---
OK!
PartiQL> SELECT tbl2.* FROM (SELECT tbl1.*, tbl1.a.b + 2 AS dervidedColumn FROM <<{'a': {'b': 2}, 'foo': 'bar', 'foo2': 'bar2'}>> AS tbl1) AS tbl2;
==='
<<
{
'a': {
'b': 2
},
'foo': 'bar',
'foo2': 'bar2',
'dervidedColumn': 4
}
>>
---
OK!
```
Fixes aggregations of attribute references to values of union types
| ) | ||
| } | ||
| ), | ||
| // TestCase.ErrorTestCase( |
There was a problem hiding this comment.
Did you mean to comment out all of these? I've gone through the post-merge commits, and there are only two things that immediately stand out to me. These commented out tests are one. The other has to do with the undefined variable returning ANY instead of MISSING.
There was a problem hiding this comment.
I did not, just need to isolate the failing tests. I will fix this ASAP
| @@ -1,68 +0,0 @@ | |||
| // package org.partiql.planner.internal | |||
There was a problem hiding this comment.
Should this file be commented out?
|
Not too sure why but some of the GitHub actions steps aren't running. Also looks like there are a few conflicts w/ the |
Yeah, that is odd. I've been seeing that from my fork recently, and I'm not sure what it's from. It'd be nice to see the passing build and the change in conformance, if any. |
|
Issue w/ the GH Actions gradle build/test step not running for |
Conformance comparison report-Cross Engine
Number failing in both: 264 Number passing in legacy engine but fail in eval engine: 776 Number failing in legacy engine but pass in eval engine: 172 Conformance comparison report-Cross Commit-LEGACY
Number failing in both: 435 Number passing in Base (5f16e67) but now fail: 1 Number failing in Base (5f16e67) but now pass: 0 Click here to see
Conformance comparison report-Cross Commit-EVAL
Number failing in both: 1008 Number passing in Base (5f16e67) but now fail: 32 Number failing in Base (5f16e67) but now pass: 14 |
Relevant Issues
N/A
Description
This PR merges the main branch into v1. We've made several changes to our typer and model. We will show some regression as operators such as COALESCE and NULLIF are not included in this PR.
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
Yes
Any backward-incompatible changes? [YES/NO]
N/A
Any new external dependencies? [YES/NO]
N/A
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
Yes
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.