Skip to content

qualified identifier #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2024
Merged

qualified identifier #1411

merged 1 commit into from
Apr 4, 2024

Conversation

yliuuuu
Copy link
Contributor

@yliuuuu yliuuuu commented Apr 3, 2024

Relevant Issues

  • [Closes/Related To] Issue #XXX

Description

  • Add grammar rule for qualified name.
  • Support Parsing for using qualified name as table name in DDL command CREATE TABLE and DROP TABLE.
  • We can reuse the rule for qualified name for other SQL object in the future if needed.

Backward compatible:

I don't think this PR is backward incompatible as the new AST carries the notion of qualified identifier, and uses the identifier as the output for CREATE TABLE and DROP TABLE node.

The grammar rule changes affected the generated Antlr Parser but no user should directly invoke the Antlr generated parser anyway (i.e., The Antlr generated parser should not be sem-ver-ed in my opinion.)

The Pig AST remains unmodified.

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]

    • Yes.
  • Any backward-incompatible changes? [YES/NO]

    • No.
  • Any new external dependencies? [YES/NO]

    • No.
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]
    Yes.

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Apr 3, 2024

Conformance comparison report

Base (db1c85b) 5aad397 +/-
% Passing 92.54% 92.54% 0.00%
✅ Passing 5384 5384 0
❌ Failing 434 434 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (db1c85b) but now fail: 0

Number failing in Base (db1c85b) but now pass: 0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (db1c85b) to head (f1823eb).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1411      +/-   ##
============================================
+ Coverage     73.14%   73.16%   +0.01%     
  Complexity     2393     2393              
============================================
  Files           247      247              
  Lines         17623    17627       +4     
  Branches       3176     3178       +2     
============================================
+ Hits          12890    12896       +6     
+ Misses         3856     3854       -2     
  Partials        877      877              
Flag Coverage Δ
CLI 11.82% <ø> (ø)
EXAMPLES 80.07% <ø> (ø)
LANG 81.06% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yliuuuu yliuuuu marked this pull request as ready for review April 4, 2024 17:33
@yliuuuu yliuuuu merged commit d059c81 into main Apr 4, 2024
@yliuuuu yliuuuu deleted the qualified-id branch April 4, 2024 20:31
rchowell pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants