Skip to content

Generate internalized planning IR #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Generate internalized planning IR #1339

merged 2 commits into from
Jan 19, 2024

Conversation

rchowell
Copy link
Contributor

@rchowell rchowell commented Jan 17, 2024

Relevant Issues

N/A

Description

Generates internalized planning IR. This simply replaces all public modifiers in the generated source with internal visibility modifiers. The only thing is that you cannot mark interface methods as internal (only the class) hence the skipping of override/fun visit.

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]
    No

  • Any backward-incompatible changes? [YES/NO]
    No

  • Any new external dependencies? [YES/NO]

    • < If YES, which ones and why? >
    • < In addition, please also mention any other alternatives you've considered and the reason they've been discarded >
      No
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]
    Yes

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Jan 17, 2024

Conformance comparison report

Base (05c591c) 3732001 +/-
% Passing 92.54% 92.54% 0.00%
✅ Passing 5384 5384 0
❌ Failing 434 434 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (05c591c) but now fail: 0

Number failing in Base (05c591c) but now pass: 0

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (dae1ab3) 72.17% compared to head (5b89f3d) 72.15%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../org/partiql/lang/syntax/impl/PartiQLPigVisitor.kt 90.24% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1339      +/-   ##
============================================
- Coverage     72.17%   72.15%   -0.02%     
+ Complexity     2097     2095       -2     
============================================
  Files           221      221              
  Lines         15973    15984      +11     
  Branches       2892     2896       +4     
============================================
+ Hits          11528    11534       +6     
- Misses         3639     3641       +2     
- Partials        806      809       +3     
Flag Coverage Δ
CLI 11.86% <ø> (ø)
EXAMPLES 80.28% <ø> (ø)
LANG 80.78% <90.24%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rchowell rchowell requested a review from alancai98 January 18, 2024 21:01
@rchowell rchowell merged commit d37369e into main Jan 19, 2024
@rchowell rchowell deleted the sprout-internal branch January 19, 2024 18:37
rchowell added a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants