Skip to content

fix: redirect issues for hydra integration in domain (not port) based env #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

programmador
Copy link
Contributor

Related issue

#67

Proposed changes

  1. Replace 'host' header while communicating with kratos to prevent reverse-proxy misbehaviour - see Redirect loop on domain-based configurations #60 . Fixes 302 redirect error with Traefik. Probably with nginx there will be another error: the wrong host will respond to http query. Therefore response will obviously have unexpected content.
  2. Make code read Hydra URL from config instead of reading from env var directly. As as side effect it removes trailing slash which fixes 307 redirect error while communicating with Hydra (either in domain-based env or I just have env vars misconfigured - I don't know and it dows not matter because anyway there is no need to read anything from env when we do already have everything in config)

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

@aeneasr
Copy link
Member

aeneasr commented Aug 3, 2020

Nice, this makes sense!

@aeneasr aeneasr merged commit c667c52 into ory:hydra-integration Aug 3, 2020
@programmador programmador deleted the feature/hydra-integration-fork branch August 3, 2020 09:29
aeneasr pushed a commit that referenced this pull request Feb 8, 2021
…a-1.8.5 (#108)

Also removed all unnecessary deltas over master.

Based on previous commits in hydra-integration branch by:

- Kim Neunert <[email protected]>
- Jeremy Bogle <[email protected]>
- hackerman <[email protected]>
- Alexander Konotop <[email protected]>

Other squashed commit messages:

- preliminary ORY Hydra integration (#50)
- fix: redirect issues for hydra integration in domain (not port) based env (#68)
  See #67
supercairos pushed a commit to supercairos/kratos-selfservice-ui-node that referenced this pull request Feb 14, 2022
…a-1.10.6 (ory#108)

Also removed all unnecessary deltas over master.

Based on previous commits in hydra-integration branch by:

- Kim Neunert <[email protected]>
- Jeremy Bogle <[email protected]>
- hackerman <[email protected]>
- Alexander Konotop <[email protected]>

Other squashed commit messages:

- preliminary ORY Hydra integration (ory#50)
- fix: redirect issues for hydra integration in domain (not port) based env (ory#68)
  See ory#67
supercairos pushed a commit to supercairos/kratos-selfservice-ui-node that referenced this pull request Feb 18, 2022
…a-1.10.6 (ory#108)

Also removed all unnecessary deltas over master.

Based on previous commits in hydra-integration branch by:

- Kim Neunert <[email protected]>
- Jeremy Bogle <[email protected]>
- hackerman <[email protected]>
- Alexander Konotop <[email protected]>

Other squashed commit messages:

- preliminary ORY Hydra integration (ory#50)
- fix: redirect issues for hydra integration in domain (not port) based env (ory#68)
  See ory#67
aeneasr added a commit to ory/kratos that referenced this pull request Oct 26, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants