fix: Make hydra integration branch compatible with kratos-0.5.4, hydra-1.8.5

[ericb-summit]

Also removed all unnecessary deltas over master.

Based on previous commits in hydra-integration branch by:

• Kim Neunert [email protected]
• Jeremy Bogle [email protected]
• hackerman [email protected]
• Alexander Konotop [email protected]

Other squashed commit messages:

• preliminary ORY Hydra integration (Integrating Hydra and Kratos #50)
• fix: redirect issues for hydra integration in domain (not port) based env (fix: redirect issues for hydra integration in domain (not port) based env #68)
  See Redirects and wrong headers in hydra integration branch #67

Related issue

Sending PR as discussed with @vinckr on slack

Proposed changes

This PR makes the hydra-integration branch work with recent version components, kratos-0.5.4, hydra-1.8.5

Other irrelevant changes of hydra-integration over master (formatting, coded moved around, console vs logger) were removed, so next person doing a rebase can do so more easily.

Affected code is formatted using npm run format, unaffected code is not. npm test seems fine, not aware of any other tests. Known issue of the hydra_integration branch, works on firefox, not on chrome (I may tackle that later); that issue persists.

Checklist

• I have read the contributing guidelines
  and signed the CLA.
• I have read the security policy.
• I confirm that this pull request does not address a security
  vulnerability. If this pull request addresses a security vulnerability, I
  confirm that I got green light (please contact
  [email protected]) from the maintainers to push
  the changes.
• I have added tests that prove my fix is effective or that my feature
  works.
• I have added necessary documentation within the code base (if
  appropriate).

Further comments

We really ought to add some coverage to this.

[vinckr]

Beautiful PR :)
I will check it out over the weekend!

[ericb-summit]

Cool. FYI, circleci fails because the base (master) is not prettied. I don't think it a good idea to add unrelated stuff to this PR.

[aeneasr]

Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)

[ericb-summit]

@aeneasr updated per your comments.

Given these changes have no impact on how the project works if not integrated with hydra, can I suggest that we merge this to master?

This way, as the kratos/hydra APIs are updated, the hydra.ts code will at a minimum compile.

[aeneasr]

Given these changes have no impact on how the project works if not integrated with hydra, can I suggest that we merge this to master?

This way, as the kratos/hydra APIs are updated, the hydra.ts code will at a minimum compile.

First of all, thank you for your effort! The reason I am reluctant to merge this into master is that we did not properly audit it and that there are no e2e tests. Otherwise I would be completely open to adopt it in the master branch!

[aeneasr]

I would move this key under hydra and also prefix it HYDRA_COOKIE_SECRET

[ericb-summit]

Agreed

[ericb-summit]

First of all, thank you for your effort! The reason I am reluctant to merge this into master is that we did not properly audit it and that there are no e2e tests. Otherwise I would be completely open to adopt it in the master branch!

Fair enough. I changed the target branch back to hydra-integration-2021.

[ericb-summit]

BTW, what framework would we use to add tests to this?

[aeneasr]

BTW, what framework would we use to add tests to this?

Basically we check out the repo in ory kratos and start it up together with some databases and kratos itself, and then run cypress tests: https://github.com/ory/kratos/tree/master/test/e2e

I will now look over your changes!

[aeneasr]

Oh and could you please run npm run format to pass the CI? :)

[aeneasr]

Awesome 🎉

Thank you for your contribution! (everthing except format looks good!)

[ericb-summit]

Oh and could you please run npm run format to pass the CI? :)

Actually there were changes the format in package.json, that's wht broke CI. I reverted, now it passes.

[aeneasr]

🥳