Make Hydra integration compatible with kratos-0.7.6, hydra-1.10.6 #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Perhaps creating a new branch from this PR is a better idea than merging it into the current hydra integration branch |
|
Thank you so much for this work and sorry for not reviewing it. We are currently planning to add native integration between Hydra and Kratos so while this work is highly appreciated, I think it will no longer be needed in a month or two :) |
|
We're now working on a native integration, which you can find here: ory/kratos#2549 :) |
aeneasr
added a commit
to ory/kratos
that referenced
this pull request
Oct 26, 2022
This feature allows Ory Kratos to act as a login provider for Ory Hydra using the `oauth2_provider.url` configuration value. Closes #273 Closes #2293 See ory/kratos-selfservice-ui-node#50 See ory/kratos-selfservice-ui-node#68 See ory/kratos-selfservice-ui-node#108 See ory/kratos-selfservice-ui-node#111 See ory/kratos-selfservice-ui-node#149 See ory/kratos-selfservice-ui-node#170 See ory/kratos-selfservice-ui-node#198 See ory/kratos-selfservice-ui-node#207
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
This feature allows Ory Kratos to act as a login provider for Ory Hydra using the `oauth2_provider.url` configuration value. Closes ory#273 Closes ory#2293 See ory/kratos-selfservice-ui-node#50 See ory/kratos-selfservice-ui-node#68 See ory/kratos-selfservice-ui-node#108 See ory/kratos-selfservice-ui-node#111 See ory/kratos-selfservice-ui-node#149 See ory/kratos-selfservice-ui-node#170 See ory/kratos-selfservice-ui-node#198 See ory/kratos-selfservice-ui-node#207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Not an issue on GH (yet), but the
hydra-integrationandhydra-integration-2021branches are very outdated and don't work with the latest Kratos and Hydra releasesProposed changes
This PR makes the hydra-integration branch work with recent version components, kratos-0.7.6, hydra-1.10.6
Affected code is formatted using npm run format, unaffected code is not. npm test seems fine, not aware of any other tests.
Checklist
and signed the CLA.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
appropriate).