-
Notifications
You must be signed in to change notification settings - Fork 199
Add preset for climbing=route
point, way and relation
#1598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I will ask for some more feedback because I did not review relations before…
This comment was marked as off-topic.
This comment was marked as off-topic.
8970840
to
ce31ec4
Compare
I just re-based this PR and included the fields added in #1590 in the route presets, so I think this PR is now ready to go. If you prefer, I can split the relation part out into a separate PR. |
TBH it feels weird to promote the fields for routes-way, route-relation and route-bottom which are all part of the same "object" (🔗 ). I guess the data users and consumers will have to keep an eye on double tagging and the resulting missmatch in data and come up with a proposal to clean this up later. Ideally only the route-bottom would hold the tags which is likely the lowest common denominator.
No, it all looks good to me. I will wait until the weekend to give people I pinged time to have a look but otherwise merge. We can always fix things later :-). |
I agree that adding fields to both the I think the best option for cleanup here is to propose a change where
That way we won't have potential for double tagging, and we also align tagging of directionality with how it's done for other features in OSM, e.g. highways. It's also an easier schema to follow, because I don't think a user today will necessarily know that they should also add a |
Was there any interest from the people you pinged over the weekend? If there was no interest and you're still uncertain about the relation part, my offer of splitting the PR remains open. From what I can see though, the relation schema works as well as can be hoped for in iD at the moment, so I'm not too concerned with just merging it as it is. And if issues do arise after merge, I'd be more than happy to help in resolving them. |
climbing=route
climbing=route
point, way and relation
Sorry for jumping in a bit late here, but I noticed that we now have two presets with the same name "Climbing Route". One for the lines and one for the Intuitively, it would make sense to also have relations for climbing routes (that perhaps also include also the access paths to the route bottom, etc.), but those should be properly defined, discussed and documented fist, shouldn't they? |
@harahu this #1598 (comment) is best answered by you. I did in fact not check what Martin mentioned but only the route example from the preview which would then be one of those 5. |
The route relation style is in fact mentioned in the wiki. Here: https://wiki.openstreetmap.org/wiki/Climbing#Multi-Pitch
I'll admit, it's not the clearest unambiguous description, but I think the schema in this PR is a sensible interpretation. What do you think, @tyrasd @tordans? |
Description, Motivation & Context
This PR is part of a larger effort to add support for rock climbing related features to iD. In this PR we add a preset for a climbing route. A climbing route is a is a path by which a climber reaches the top of a mountain, a rock face or an ice-covered obstacle. A climbing route can be mapped as a single line tagged
climbing=route
, or, a relation of lines, possibly including connecting paths. Climbing routes are currently in active use by data consumers, e.g. openclimbing.org.Climbing routes can be equipped with additional fields, in addition to a name. Useful information could be the difficulty rating of the route (grade) and the type of protection used on the route, as well as the 3D length of the route. I've consciously decided to leave such fields out of this PR, since these are covered in #1590. This PR could be merged independently, and we can update the fields of the preset once that PR is merged.
I've set up a Wikibase entry and a corresponding article for climbing routes, which can be found here:
https://wiki.openstreetmap.org/wiki/Item:Q23048
https://wiki.openstreetmap.org/wiki/Tag:climbing%3Droute
Related issues
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
https://taginfo.openstreetmap.org/tags/climbing=route
https://taghistory.raifer.tech/#***/climbing/route
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.