Skip to content

Add preset for climbing=crag point and relation #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2025

Conversation

harahu
Copy link
Contributor

@harahu harahu commented Jun 12, 2025

Description, Motivation & Context

This PR is part of a larger effort to add support for rock climbing related features to iD. In this PR we add a preset for a climbing "crag", which is understood to be a grouping of distinct climbing routes that are located at most a few minutes walk from each other, usually on the same cliff face. Climbing crags are currently in active use by data consumers, e.g. openclimbing.org.

Climbing crags can be equipped with additional fields, in addition to a name. Usually this would be tags representing summary statistics for the routes contained within the crag. I've consciously decided to leave such fields out of this PR, since in practice all this information can be computed from the member objects, if the crag is represented as a relation. If the crag is rather represented as a point or a cliff line, such additional tagging could be helpful, but I'd rather encourage mapping crags as relations of routes, since this increases the value of the data available in OSM.

I've set up a Wikibase entry and a corresponding article for climbing areas, which can be found here:
https://wiki.openstreetmap.org/wiki/Item:Q23047
https://wiki.openstreetmap.org/wiki/Tag:climbing%3Dcrag

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:
https://taginfo.openstreetmap.org/tags/climbing=crag
https://taghistory.raifer.tech/#***/climbing/crag

5868 current uses

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@harahu
Copy link
Contributor Author

harahu commented Jun 12, 2025

@harahu harahu mentioned this pull request Jun 13, 2025
Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. One thing about lines/areas that we should think about.

As with #1598 I hope for input from others about the relation part of this PR.

@harahu harahu requested a review from tordans June 15, 2025 17:46
@tordans tordans added new-preset waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. labels Jun 15, 2025
@tordans tordans changed the title Add preset for climbing=crag Add preset for climbing=crag point and relation Jun 24, 2025
@tordans tordans merged commit e7dcdd8 into openstreetmap:main Jun 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-preset waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants