-
Notifications
You must be signed in to change notification settings - Fork 199
Add preset for climbing=crag
point and relation
#1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
Test-DocumentationPreview links & Sidebar Screenshotshttps://pr-1597--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.24/59.86893/5.95401&disable_features=boundaries&background=geovekst-nib&id=r19141778 https://pr-1597--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=18.81/59.86978/5.99424&disable_features=boundaries&background=geovekst-nib&id=n12848932790 Search![]() ![]() Info-
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. One thing about lines/areas that we should think about.
As with #1598 I hope for input from others about the relation part of this PR.
climbing=crag
climbing=crag
point and relation
Description, Motivation & Context
This PR is part of a larger effort to add support for rock climbing related features to iD. In this PR we add a preset for a climbing "crag", which is understood to be a grouping of distinct climbing routes that are located at most a few minutes walk from each other, usually on the same cliff face. Climbing crags are currently in active use by data consumers, e.g. openclimbing.org.
Climbing crags can be equipped with additional fields, in addition to a name. Usually this would be tags representing summary statistics for the routes contained within the crag. I've consciously decided to leave such fields out of this PR, since in practice all this information can be computed from the member objects, if the crag is represented as a relation. If the crag is rather represented as a point or a cliff line, such additional tagging could be helpful, but I'd rather encourage mapping crags as relations of routes, since this increases the value of the data available in OSM.
I've set up a Wikibase entry and a corresponding article for climbing areas, which can be found here:
https://wiki.openstreetmap.org/wiki/Item:Q23047
https://wiki.openstreetmap.org/wiki/Tag:climbing%3Dcrag
Related issues
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
https://taginfo.openstreetmap.org/tags/climbing=crag
https://taghistory.raifer.tech/#***/climbing/crag
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.