MCO: allow ssh #2817
MCO: allow ssh #2817
Conversation
openshift-ci-robot
added
the
size/XS
Signed-off-by: Antonio Murdaca <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@runcom: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Mmm this has broken tests completely somehow https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/390/pull-ci-openshift-machine-config-operator-master-e2e-aws-op/361 |
| @@ -40,6 +40,7 @@ build_root: | |||
| name: release | |||
| namespace: openshift | |||
| tag: golang-1.10 | |||
| test_binary_build_commands: chmod uga+w /etc/passwd | |||
There was a problem hiding this comment.
ok, this was wrong, my understanding is that test_binary_build_commands is ran for the test-bin image but in e2e-aws-go we're not using test-bin (there's no container: from: test-bin). I don't believe we can use binary_build_commands as we don't seem to be using the bin image either afaict (just plan src) (for reference https://github.com/openshift/ci-operator/blob/master/CONFIGURATION.md#binary_build_commands)
not sure what to do actually, @stevekuznetsov @smarterclayton wdyt?
There was a problem hiding this comment.
ok we're using openshift_installer_src so we're using the src image by default anyway for e2e-aws-go, that's why chmod is not executed nor it would be using binary_build_commands.
We want to have tests in MCO which rely on ssh and a valid user in /etc/passwd to have ssh working (openshift/machine-config-operator#390)
Signed-off-by: Antonio Murdaca [email protected]