test/e2e: add tests around ssh/accessed annotation #390

runcom · 2019-02-07T15:34:32Z

Testing we correctly add the ssh accessed annotation on any given node accessed with ssh, there are other permutation of the test to be added though (annotation also on degraded etc etc, I'm working on that but I'd love #387 to land first so I can use that code to create MCs and degrade machines)

- add ssh/accessed annotation test
- add test no accessed on reboot

Signed-off-by: Antonio Murdaca [email protected]

test/e2e/mcd_test.go

runcom · 2019-02-07T17:10:15Z

/retest

ashcrow · 2019-02-07T17:24:37Z

test/e2e/mcd_test.go

+	if err != nil {
+		t.Errorf("cannot get node %q: %v", nodeName, err)
+	}
+	sshAnnotation, ok := node.ObjectMeta.Annotations["machineconfiguration.openshift.io/ssh"]


nit: It may be worth using the constants: https://github.com/openshift/machine-config-operator/blob/master/pkg/daemon/constants.go#L34-L37

cgwalters · 2019-02-07T17:53:21Z

test/e2e/mcd_test.go

+		t.Errorf("node %q has ssh/accessed annotation but it shouldn't", nodeName)
+	}
+
+	cmd := exec.Command("ssh", "-oStrictHostKeyChecking=no", "core@"+nodeIP, "true")


Let's be nice to people who are running this locally and also add -oUserKnownHostsFile=/dev/null to not add junk to their ~/.ssh/known_hosts.

runcom · 2019-02-07T18:04:32Z

tests are flaking like crazy now, I'll stop retesting but I need to investigate why ssh fails to connect to the node from within the test container (which I've spotted on an early run)

cgwalters · 2019-02-07T18:12:01Z

need to investigate why ssh fails to connect to the node from within the test container

It looks like the e2e suite does this:
export KUBE_SSH_KEY_PATH=/tmp/cluster/ssh-privatekey

runcom · 2019-02-07T18:12:52Z

@cgwalters thanks a lot!

runcom · 2019-02-07T22:04:42Z

updated

runcom · 2019-02-07T23:49:23Z

/retest

cgwalters · 2019-02-08T00:22:15Z

/lgtm

openshift-ci-robot · 2019-02-08T00:22:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ashcrow,cgwalters,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2019-02-08T10:04:30Z

New changes are detected. LGTM label has been removed.

runcom · 2019-02-08T10:58:50Z

~~This still fails on the ssh command for some reason, need to understand why~~ gotcha

runcom · 2019-02-08T11:45:07Z

alright, now that I was on it, I've added another test and a todo as well along with some refactor.

cgwalters · 2019-02-08T13:50:09Z

I should have remembered; we dropped direct ssh to masters/nodes by default. See
openshift/release#2469

ashcrow · 2019-02-08T14:05:24Z

	mcd_test.go:269: error ssh'ing into node ".....": exit status 255, No user exists for uid 1122740000

- add ssh/accessed annotation test - add test no accessed on reboot Signed-off-by: Antonio Murdaca <[email protected]>

runcom · 2019-02-08T14:56:22Z

holding cause we're discussing ssh tests and testing in general on Slack/emails

I might pull off the second test from here cause it doesn't need ssh connections

/hold

runcom · 2019-02-08T17:41:59Z

/retest

runcom · 2019-02-08T18:32:26Z

well, the bastion host env isn't really helping either, damn

runcom · 2019-02-08T20:30:36Z

This openshift/release#2817 should unblock us here

runcom · 2019-02-08T22:02:19Z

/retest

runcom · 2019-02-12T15:31:10Z

test/e2e/mcd_test.go

 	listOptions := metav1.ListOptions{
 		LabelSelector: labels.SelectorFromSet(labels.Set{"k8s-app": "machine-config-daemon"}).String(),
 	}

-	err = wait.Poll(3*time.Second, 5*time.Minute, func() (bool, error) {
-		mcdList, err := k.CoreV1().Pods("openshift-machine-config-operator").List(listOptions)
+	var seen int


note to self, this has to be moved within the wait call to be right

openshift-ci-robot · 2019-02-18T10:04:10Z

@runcom: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-11-30T13:30:07Z

@runcom: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	`b4200fb`	link	`/test e2e-aws`
ci/prow/e2e-aws-op	`b4200fb`	link	`/test e2e-aws-op`
ci/prow/e2e-aws-disruptive	`b4200fb`	link	`/test e2e-aws-disruptive`
ci/prow/e2e-gcp-op	`b4200fb`	link	`/test e2e-gcp-op`
ci/prow/e2e-aws-upgrade	`b4200fb`	link	`/test e2e-aws-upgrade`
ci/prow/e2e-gcp-upgrade	`b4200fb`	link	`/test e2e-gcp-upgrade`
ci/prow/e2e-vsphere	`b4200fb`	link	`/test e2e-vsphere`
ci/prow/build-rpms-from-tar	`b4200fb`	link	`/test build-rpms-from-tar`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kikisdeliveryservice · 2019-12-03T22:32:32Z

In an effort to clean up the MCO repo, closing old open PRs with no activity.

Feel free to reopen.

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 7, 2019

openshift-ci-robot requested review from smarterclayton and wking February 7, 2019 15:34

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2019

jlebon reviewed Feb 7, 2019

View reviewed changes

test/e2e/mcd_test.go Outdated Show resolved Hide resolved

runcom force-pushed the ssh-tests branch from bf0cf01 to dea61f7 Compare February 7, 2019 15:55

runcom force-pushed the ssh-tests branch from dea61f7 to f3fc8cd Compare February 7, 2019 17:10

ashcrow reviewed Feb 7, 2019

View reviewed changes

runcom force-pushed the ssh-tests branch from f3fc8cd to 8f629b9 Compare February 7, 2019 17:27

ashcrow approved these changes Feb 7, 2019

View reviewed changes

cgwalters reviewed Feb 7, 2019

View reviewed changes

runcom force-pushed the ssh-tests branch 2 times, most recently from 9c456c5 to f06b54d Compare February 7, 2019 22:03

openshift-ci-robot assigned cgwalters Feb 8, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019

runcom force-pushed the ssh-tests branch from f06b54d to f29b6ee Compare February 8, 2019 10:03

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019

runcom force-pushed the ssh-tests branch from f29b6ee to af5b0d0 Compare February 8, 2019 11:44

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2019

runcom changed the title ~~test/e2e: add ssh/accessed annotation test~~ test/e2e: add tests around ssh/accessed annotation Feb 8, 2019

runcom force-pushed the ssh-tests branch from af5b0d0 to f2c39ff Compare February 8, 2019 14:14

test/e2e: add tests around ssh/accessed annotation

b4200fb

- add ssh/accessed annotation test - add test no accessed on reboot Signed-off-by: Antonio Murdaca <[email protected]>

runcom force-pushed the ssh-tests branch from f2c39ff to b4200fb Compare February 8, 2019 14:38

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2019

runcom mentioned this pull request Feb 8, 2019

MCO: allow ssh openshift/release#2817

Merged

runcom commented Feb 12, 2019

View reviewed changes

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2019

kikisdeliveryservice closed this Dec 3, 2019

kikisdeliveryservice added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 3, 2019

test/e2e: add tests around ssh/accessed annotation #390

test/e2e: add tests around ssh/accessed annotation #390

Uh oh!

Conversation

runcom commented Feb 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

runcom commented Feb 7, 2019

Uh oh!

ashcrow Feb 7, 2019

Choose a reason for hiding this comment

Uh oh!

runcom Feb 7, 2019

Choose a reason for hiding this comment

Uh oh!

cgwalters Feb 7, 2019

Choose a reason for hiding this comment

Uh oh!

runcom commented Feb 7, 2019

Uh oh!

cgwalters commented Feb 7, 2019

Uh oh!

runcom commented Feb 7, 2019

Uh oh!

runcom commented Feb 7, 2019

Uh oh!

runcom commented Feb 7, 2019

Uh oh!

cgwalters commented Feb 8, 2019

Uh oh!

openshift-ci-robot commented Feb 8, 2019

Uh oh!

openshift-ci-robot commented Feb 8, 2019

Uh oh!

runcom commented Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

runcom commented Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cgwalters commented Feb 8, 2019

Uh oh!

ashcrow commented Feb 8, 2019

Uh oh!

runcom commented Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

runcom commented Feb 8, 2019

Uh oh!

runcom commented Feb 8, 2019

Uh oh!

runcom commented Feb 8, 2019

Uh oh!

runcom commented Feb 8, 2019

Uh oh!

runcom Feb 12, 2019

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Feb 18, 2019

Uh oh!

openshift-ci-robot commented Nov 30, 2019

Uh oh!

kikisdeliveryservice commented Dec 3, 2019

Uh oh!

Uh oh!

runcom commented Feb 7, 2019 •

edited

Loading

runcom commented Feb 8, 2019 •

edited

Loading

runcom commented Feb 8, 2019 •

edited

Loading

runcom commented Feb 8, 2019 •

edited

Loading