-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Revert "MCO: allow ssh" #2819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "MCO: allow ssh" #2819
Conversation
This reverts commit bbdd61e. Signed-off-by: Antonio Murdaca <[email protected]>
@@ -40,7 +40,6 @@ build_root: | |||
name: release | |||
namespace: openshift | |||
tag: golang-1.10 | |||
test_binary_build_commands: chmod uga+w /etc/passwd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, we basically need this chmod
in the src
image from what I can tell since we're using openshift_installer_src
and we're in src
anyway
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@runcom: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This reverts commit bbdd61e.
Still need to find a way to poke with
/etc/passwd
but with this our CI is busted fore2e-aws-op
, still trying to find a way though, if there's anThis is why it broke https://github.com/openshift/release/pull/2817/files#r255281382
This is an example failure we're now getting https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/390/pull-ci-openshift-machine-config-operator-master-e2e-aws-op/361
Signed-off-by: Antonio Murdaca [email protected]