Skip to content

Revert "MCO: allow ssh" #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2019

Conversation

runcom
Copy link
Member

@runcom runcom commented Feb 9, 2019

This reverts commit bbdd61e.

Still need to find a way to poke with /etc/passwd but with this our CI is busted for e2e-aws-op, still trying to find a way though, if there's an

This is why it broke https://github.com/openshift/release/pull/2817/files#r255281382
This is an example failure we're now getting https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/390/pull-ci-openshift-machine-config-operator-master-e2e-aws-op/361

Signed-off-by: Antonio Murdaca [email protected]

This reverts commit bbdd61e.

Signed-off-by: Antonio Murdaca <[email protected]>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2019
@@ -40,7 +40,6 @@ build_root:
name: release
namespace: openshift
tag: golang-1.10
test_binary_build_commands: chmod uga+w /etc/passwd
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, we basically need this chmod in the src image from what I can tell since we're using openshift_installer_src and we're in src anyway

@runcom runcom mentioned this pull request Feb 9, 2019
@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit a59e9bf into openshift:master Feb 9, 2019
@openshift-ci-robot
Copy link
Contributor

@runcom: Updated the following 3 configmaps:

  • job-config configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
  • ci-operator-configs configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-configs configmap in namespace ci-stg using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml

In response to this:

This reverts commit bbdd61e.

Still need to find a way to poke with /etc/passwd but with this our CI is busted for e2e-aws-op, still trying to find a way though, if there's an

This is why it broke https://github.com/openshift/release/pull/2817/files#r255281382
This is an example failure we're now getting https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/390/pull-ci-openshift-machine-config-operator-master-e2e-aws-op/361

Signed-off-by: Antonio Murdaca [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants