UPSTREAM: 76455: More flake fixes in HPA legacy tests

[joelsmith]

See kubernetes/kubernetes#76455
This is the second half of the fixes from the upstream PR. Hopefully it will take care of https://bugzilla.redhat.com/show_bug.cgi?id=1695326
(Here's the first half: #22531)

[joelsmith]

@RobertKrawitz PTAL. Thanks!

[RobertKrawitz]

I notice around line 529 there's a somewhat funky construct where it sends to the processed channel before setting tc.finished. Could you take a look at that also? That looks like a potential race condition itself.

[joelsmith]

It's reading from the chan (and ignoring what it reads), not writing to it. So it's waiting for at least one event to come through on the chan before proceeding.

[RobertKrawitz]

It's reading from the chan (and ignoring what it reads), not writing to it. So it's waiting for at least one event to come through on the chan before proceeding.

+1

[RobertKrawitz]

/lgtm

[RobertKrawitz]

/lgtm cancel
The UT failure looks like it's unrelated, but please verify that.

[joelsmith]

/retest

[joelsmith]

Looks like the unit test was just an unrelated flake as suspected. And now we wait another 2 hours to see if we can get e2e-aws-serial to pass.
/retest

[RobertKrawitz]

/lgtm

UT flakes aren't at all good, but there's no apparent connection between what failed and the test that this fixes.

[sjenning]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, RobertKrawitz, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• vendor/k8s.io/kubernetes/pkg/controller/OWNERS [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@joelsmith: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-serial	7383419	link	/test e2e-aws-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.