Skip to content

UPSTREAM: 76455: Fix flakes in HPA tests #22531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2019
Merged

UPSTREAM: 76455: Fix flakes in HPA tests #22531

merged 1 commit into from
Apr 13, 2019

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Apr 10, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 10, 2019
@joelsmith joelsmith mentioned this pull request Apr 10, 2019
Merged
@joelsmith
Copy link
Contributor Author

/retest

@joelsmith
Copy link
Contributor Author

retest didn't trigger. Closing and re-opening to see if that will do it.

@joelsmith joelsmith closed this Apr 11, 2019
@joelsmith joelsmith reopened this Apr 11, 2019
@joelsmith
Copy link
Contributor Author

I'm going to have the unit test run as many times as possible
/test unit

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2019
@joelsmith joelsmith changed the title WIP: Fix flakes in HPA tests UPSTREAM: <drop>: Fix flakes in HPA tests Apr 11, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2019
@joelsmith
Copy link
Contributor Author

Even doing many runs of the unit test CI job the flake hasn't popped up (see https://openshift-gce-devel.appspot.com/builds/origin-ci-test/pr-logs/pull/22531/pull-ci-openshift-origin-master-unit/ where none of the flakes were this one).

Seth, could you please review this? Clayton, are we okay to merge this and will you be reworking #22527?

/assign @sjenning
/cc @smarterclayton

@joelsmith
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2019
@joelsmith
Copy link
Contributor Author

As suggested by @RobertKrawitz, changed to only write to the chan while not holding the lock. This should make it impossible to hit the kind of deadlock we were seeing before.

@RobertKrawitz
Copy link
Contributor

After discussion in slack,
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@RobertKrawitz
Copy link
Contributor

/assign sjenning

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@joelsmith
Copy link
Contributor Author

I squashed and changed the commit message to reference the upstream PR kubernetes/kubernetes#76455

@joelsmith joelsmith changed the title UPSTREAM: <drop>: Fix flakes in HPA tests UPSTREAM: 76455: Fix flakes in HPA tests Apr 11, 2019
@RobertKrawitz
Copy link
Contributor

/lgtm
/assign sjenning

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@RobertKrawitz
Copy link
Contributor

/assign @sjenning

@smarterclayton
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, RobertKrawitz, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@soltysh
Copy link
Contributor

soltysh commented Apr 12, 2019

/refresh

@soltysh
Copy link
Contributor

soltysh commented Apr 12, 2019

/retest

@droslean
Copy link
Member

/test e2e-aws-serial

@sjenning
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e4a821a into openshift:master Apr 13, 2019
@joelsmith joelsmith mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@sjenning sjenning

@RobertKrawitz RobertKrawitz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@joelsmith @RobertKrawitz @smarterclayton @openshift-ci-robot @soltysh @droslean @sjenning @openshift-bot @openshift-merge-robot