Skip to content

Drop deprecated namespace from tests #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Drop deprecated namespace from tests #203

wants to merge 1 commit into from

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Feb 8, 2019 •
edited
Loading

@enxebre
Copy link
Member Author

enxebre commented Feb 8, 2019

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2019
@enxebre enxebre changed the title Drop deprecated namespace Drop deprecated namespace from tests Feb 11, 2019
@enxebre enxebre mentioned this pull request Feb 11, 2019
Merged
@enxebre enxebre force-pushed the drop-deprecated-namespace branch from 4c96bb6 to 6a362a1 Compare February 12, 2019 08:13
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2019
@enxebre enxebre added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
@frobware
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@enxebre
Copy link
Member Author

enxebre commented Feb 12, 2019

/test e2e-aws-operator

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@enxebre
Copy link
Member Author

enxebre commented Feb 12, 2019

/test e2e-aws-operator

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@enxebre
Copy link
Member Author

enxebre commented Feb 13, 2019

Since openshift/installer#1241 got in, test should go through now
/test e2e-aws-operator

@enxebre
Copy link
Member Author

enxebre commented Feb 13, 2019

/test e2e-aws-operator

@enxebre
Copy link
Member Author

enxebre commented Feb 13, 2019 •
edited
Loading

CI still not used fixed version of installer (unreleased-master-281-g4bd58eb3d5a82058175d86f23ac6401aa70393a6) using previews commit instead https://storage.googleapis.com/origin-ci-test/pr-logs/pull/22008/pull-ci-openshift-origin-master-e2e-aws/3869/artifacts/e2e-aws/installer/version

It should pick the fix since the installer image was built https://deck-ci.svc.ci.openshift.org/?job=branch-ci-openshift-installer-master-images

/test e2e-aws-operator

@enxebre
Copy link
Member Author

enxebre commented Feb 13, 2019

/test e2e-aws-operator

1 similar comment
@enxebre
Copy link
Member Author

enxebre commented Feb 13, 2019

/test e2e-aws-operator

@enxebre enxebre mentioned this pull request Feb 13, 2019
Merged
@openshift-ci-robot
Copy link
Contributor

@enxebre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-operator 6a362a1 link /test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member Author

enxebre commented Feb 13, 2019

ci-operator namespace caching is reusing the same installer image so
closing in favour of #207

@enxebre enxebre closed this Feb 13, 2019
ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this pull request Jul 11, 2019
@openshift-merge-robot
Merge pull request openshift#203 from ingvagabund/sync-cluster-api
8f3ed44 
Sync with the latest openshift/cluster-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund approved these changes

@bison bison Awaiting requested review from bison

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

Assignees

@frobware frobware

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enxebre @frobware @openshift-ci-robot @openshift-bot @ingvagabund