Fix bug where list of masters contain all same object #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
enxebre
force-pushed
the
fixbug-masters
branch
from
6827399 to
78df105
Compare
frobware
reviewed
Feb 13, 2019
| @@ -138,11 +138,12 @@ func (m *Master) Generate(dependencies asset.Parents) error { | |||
| }} | |||
|
|
|||
| machinesAll := []runtime.Object{} | |||
| for _, machine := range machines { | |||
| machinesAll = append(machinesAll, &machine) | |||
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, flaper87, frobware The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This was referenced Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced by 0f8e6b8#diff-66b4febb36af0238bb6c09e72c1c44ecR141 which makes
machinesAllto contain the same address in every index:machinesAll: [0xc0008d2000 0xc0008d2000 0xc0008d2000]Hence the masters machine manifests rendered to disk all contain the same spec and so the same object name, hence only one machine master object is instantiated in the cluster, making the expectations of "each node having a backing machine" to fail in all our repos https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_machine-api-operator/203/pull-ci-openshift-machine-api-operator-master-e2e-aws-operator/269
Right now all our CI validations are failing because of this issue. We need to get openshift/origin#22015 merged asap to run against the installer and narrow down the window for introducing this kind of bugs and make the boundaries and integration between the tools more solid.
The programatic reasoning behind the golang issue/fix/gotcha is still not clear to me.Golang gotcha golang/go#20733This can be easily reproduced by running
./bin/openshift-install create manifestsand check the master machines manifests@wking @abhinavdahiya @derekwaynecarr @frobware @ingvagabund @crawford