-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: Chitin Builder: a VMD tool for the generation of structures of chitin molecular crystals for atomistic simulations #5771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
Failed to discover a |
|
@amoeba, @WangKehan573, have you been able to give some time to this review? Please let me know in the thread. Thanks! |
Hi @majensen, I hadn't noticed this review go from pre-review to review so thanks for the ping! I can get my review done in the next two weeks. |
Review checklist for @amoebaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @majensen, while reviewing the "Substantial scholarly effort" checklist item, I find a could use some editorial help. Using the corresponding section in the Review criteria as a guide, I think this submission is borderline due to the size and apparent age of the codebase. I don't see that this was discussed in pre review but please let me know if I missed that It seems to me the most important element of this checklist item is whether the work is of broad interest and likely to be cited which isn't something I can assess with my background. However, in the paper, the authors speak to this at the end of their Introduction and Statement of Need section and to me it sounds like they theorize this tool would be quite useful to others in their field. With that, I'm inclined to check "Substantial scholarly effort" so long as you agree. |
Sorry for the long delay @amoeba and all. I am discussing this with one of the AEICs. @jfaraudo - can you comment here on your view of the effort put into this software, and on its usefulness to the community? I think it is a specialized community, and that is ok - how do you see this work contributing to the science? |
@WangKehan573 - are you still able to review #5771? Please let me know if I can help- thanks |
I regret to inform you that I am unable to review the material you have submitted due to circumstances beyond my control. Unfortunately, I am experiencing unforeseen challenges that are preventing me from fulfilling my responsibility as a reviewer.
I apologize for any inconvenience this may cause and I assure you that I am doing my best to resolve the situation. I hope you can understand and forgive my inability to meet my commitments at this time.
Thank you for your understanding
…---- Replied Message ----
| From | Mark ***@***.***> |
| Date | 11/02/2023 22:56 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [openjournals/joss-reviews] [REVIEW]: Chitin Builder: a VMD tool for the generation of structures of chitin molecular crystals for atomistic simulations (Issue #5771) |
@WangKehan573 - are you still able to review #5771? Please let me know if I can help- thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@majensen Yes, sure, we can comment on this here.
|
Thanks @jfaraudo - I have also spent some time getting a deeper understanding of the VMD framework, which it is very current use, with new plugins written for it frequently up to the present time (even though it was published first around 1996). @amoeba I would call it the "Emacs of Molecular Modeling". I have not heard any disagreement from the Associate Editor in Chief to this argument. So let's proceed with "Substantial scholarly effort". |
@jfaraudo -- unfortunately one of our reviewers had to decline. I am sorry about the very long delay. Would you have any suggestions for reviewers with the right expertise who could fairly review your work? Much appreciated! |
Thanks for taking a look, @majensen. Works for me. |
Sorry for the delay in responding. I think apropiate referees could be developers of other VMD plugins. One example is Dr Toni Giorgino @tonigi [ https://github.com/tonigi | https://github.com/tonigi ]
Let me think about others.
jordi
From: "Mark Jensen" ***@***.***>
To: "openjournals/joss-reviews" ***@***.***>
Cc: "Jordi Faraudo" ***@***.***>, "Mention" ***@***.***>
Sent: Thursday, 16 November, 2023 23:15:28
Subject: Re: [openjournals/joss-reviews] [REVIEW]: Chitin Builder: a VMD tool for the generation of structures of chitin molecular crystals for atomistic simulations (Issue #5771)
[ https://urldefense.com/v3/__https://github.com/jfaraudo__;!!D9dNQwwGXtA!SoVYcjZdOWxeXeN0LHD9qH4oQ6jNIU5hcjJUbM0yWsXZW_b9OuhoxRVV66y2u82gJIOXk1ZcVLfopsmGnCnIN695DQ$ | @jfaraudo ] -- unfortunately one of our reviewers had to decline. I am sorry about the very long delay. Would you have any suggestions for reviewers with the right expertise who could fairly review your work? Much appreciated!
—
Reply to this email directly, [ https://urldefense.com/v3/__https://github.com/openjournals/joss-reviews/issues/5771*issuecomment-1815400010__;Iw!!D9dNQwwGXtA!SoVYcjZdOWxeXeN0LHD9qH4oQ6jNIU5hcjJUbM0yWsXZW_b9OuhoxRVV66y2u82gJIOXk1ZcVLfopsmGnCkvMKOaXw$ | view it on GitHub ] , or [ https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AHFLNXQOV2VH55UJH6W5273YE2GABAVCNFSM6AAAAAA3XYVVACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJVGQYDAMBRGA__;!!D9dNQwwGXtA!SoVYcjZdOWxeXeN0LHD9qH4oQ6jNIU5hcjJUbM0yWsXZW_b9OuhoxRVV66y2u82gJIOXk1ZcVLfopsmGnCkvfQuctQ$ | unsubscribe ] .
You are receiving this because you were mentioned. Message ID: ***@***.***>
…--
Dr. Jordi Faraudo
Institut de Ciencia de Materials de Barcelona (ICMAB-CSIC),
[ https://icmab.es/faraudo-gener-jordi-permanent-researchers | https://icmab.es/faraudo-gener-jordi-permanent-researchers ]
Associate Editor - Condensed Matter Physics @ "Heliyon" journal, [ http://www.heliyon.com/ | http://www.heliyon.com ]
Editorial Board member @ "Materials" journal, [ http://www.mdpi.com/journal/materials | http://www.mdpi.com/journal/materials ]
"It's nice to know the computer understands the problem, but I would like to understand it too."
(Attributed to Eugene Wigner)
|
I'll be happy to review. |
Thanks so much @tonigi ! |
@editorialbot add tonigi as reviewer |
@majensen Zenodo DOI https://doi.org/10.5281/zenodo.10517626 |
Thanks @jfaraudo - the journal prefers that the title and authors on the archive match those on the paper, if you can update those items. |
OK @majensen The zenodo archive was generated automatically after creating the new software version (we had an automatic update of our GitHub repo in Zenodo) and it takes as title the GitHub repo name and as authos everyone that contributed in the repo (including referees like @amoeba that did a pull request on GitHub). We will try to correct this today. If a correction is not possible we will create manually another Zenodo archive for the JOSS publication. |
@majensen Corrected, now authors and title matches that of JOSS submission and files correspond to latest repository version . Same DOI: https://zenodo.org/doi/10.5281/zenodo.3274725 |
@editorialbot set v1.1 as version |
Done! version is now v1.1 |
@editorialbot set 10.5281/zenodo.3274725 as archive |
Done! archive is now 10.5281/zenodo.3274725 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4958, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
I'm sorry @jfaraudo, I'm afraid I can't do that. That's something only eics are allowed to do. |
Everything (pdf file, etc) looks good to me. |
@jfaraudo As AEiC I will now help to process final steps towards acceptance in JOSS. I have just checked your repository, this review, the archive link, and the paper. All seems in order, so I will now proceed to accept this work. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Really great to finally get this out - thanks to all for thier perseverance! |
Submitting author: @jfaraudo (JORDI FARAUDO)
Repository: https://github.com/soft-matter-theory-at-icmab-csic/chitin_builder
Branch with paper.md (empty if default branch):
Version: v1.1
Editor: @majensen
Reviewers: @amoeba, @tonigi
Archive: 10.5281/zenodo.3274725
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@amoeba & @WangKehan573, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @majensen know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @amoeba
📝 Checklist for @tonigi
The text was updated successfully, but these errors were encountered: