Skip to content

Fix/forum patches sumac #36606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Abdul-Muqadim-Arbisoft
Copy link

This PR cherry-picks key fixes for the forum and discussion blocks from master into the open-release/sumac.master branch. These changes are required to ensure forum functionality in the Sumac release.

taimoor-ahmed-1 and others added 3 commits April 25, 2025 18:11
fix all endpoints that were currently breaking with the discussion xblock.

Co-authored-by: Taimoor  Ahmed <[email protected]>
Explicitly passed course_id to all views
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 25, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @Abdul-Muqadim-Arbisoft!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 25, 2025
@ziafazal ziafazal self-requested a review April 25, 2025 13:36
Copy link
Contributor

@taimoor-ahmed-1 taimoor-ahmed-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kdmccormick and others added 2 commits April 28, 2025 15:22
JS tests are failing because we are using a discontinued GHA caching service:
https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts

This service is used by the unsupported C-Hive caching action which we are
relying on: https://github.com/c-hive/gha-npm-cache

We are switching to the supported caching mechanims which is provided by
setup-node:
https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data
Copy link
Contributor

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ziafazal ziafazal merged commit c1804f5 into openedx:open-release/sumac.master Apr 28, 2025
49 of 50 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Apr 28, 2025
zubairshakoorarbisoft pushed a commit to zubairshakoorarbisoft/edx-platform that referenced this pull request May 9, 2025
* fix: discussion xblock not compatible with forum v2 (openedx#36315)

fix all endpoints that were currently breaking with the discussion xblock.

Co-authored-by: Taimoor  Ahmed <[email protected]>

* fix: legacy discussion issues (openedx#36433)

Explicitly passed course_id to all views

* fix: legacy forum issues (openedx#36470)

Co-authored-by: Taimoor  Ahmed <[email protected]>

* build: Switch off deprecated C-Hive NPM cache (openedx#36502)

JS tests are failing because we are using a discontinued GHA caching service:
https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts

This service is used by the unsupported C-Hive caching action which we are
relying on: https://github.com/c-hive/gha-npm-cache

We are switching to the supported caching mechanims which is provided by
setup-node:
https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data

* Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04

feanil/ubuntu 24.04

---------

Co-authored-by: Taimoor Ahmed <[email protected]>
Co-authored-by: Taimoor  Ahmed <[email protected]>
Co-authored-by: Ali Salman <[email protected]>
Co-authored-by: Kyle McCormick <[email protected]>
Co-authored-by: Feanil Patel <[email protected]>
zubairshakoorarbisoft pushed a commit to zubairshakoorarbisoft/edx-platform that referenced this pull request May 9, 2025
* fix: discussion xblock not compatible with forum v2 (openedx#36315)

fix all endpoints that were currently breaking with the discussion xblock.

Co-authored-by: Taimoor  Ahmed <[email protected]>

* fix: legacy discussion issues (openedx#36433)

Explicitly passed course_id to all views

* fix: legacy forum issues (openedx#36470)

Co-authored-by: Taimoor  Ahmed <[email protected]>

* build: Switch off deprecated C-Hive NPM cache (openedx#36502)

JS tests are failing because we are using a discontinued GHA caching service:
https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts

This service is used by the unsupported C-Hive caching action which we are
relying on: https://github.com/c-hive/gha-npm-cache

We are switching to the supported caching mechanims which is provided by
setup-node:
https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data

* Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04

feanil/ubuntu 24.04

---------

Co-authored-by: Taimoor Ahmed <[email protected]>
Co-authored-by: Taimoor  Ahmed <[email protected]>
Co-authored-by: Ali Salman <[email protected]>
Co-authored-by: Kyle McCormick <[email protected]>
Co-authored-by: Feanil Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants