fix: legacy forum issues #36470
Merged
fix: legacy forum issues #36470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @taimoor-ahmed-1! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
taimoor-ahmed-1
force-pushed
the
fix/legacy_forum_issues
branch
3 times, most recently
from
198de4e to
14eebeb
Compare
taimoor-ahmed-1
force-pushed
the
fix/legacy_forum_issues
branch
from
14eebeb to
d36ecc2
Compare
Ali-Salman29
approved these changes
Apr 7, 2025
|
LGTM! |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
irtazaakram
pushed a commit
that referenced
this pull request
Apr 10, 2025
Co-authored-by: Taimoor Ahmed <[email protected]>
This was referenced Apr 10, 2025
Agrendalath
pushed a commit
to open-craft/edx-platform
that referenced
this pull request
Apr 17, 2025
Co-authored-by: Taimoor Ahmed <[email protected]> (cherry picked from commit 0595e5a)
Agrendalath
pushed a commit
to open-craft/edx-platform
that referenced
this pull request
Apr 17, 2025
Co-authored-by: Taimoor Ahmed <[email protected]> (cherry picked from commit 0595e5a)
Agrendalath
pushed a commit
to open-craft/edx-platform
that referenced
this pull request
Apr 22, 2025
Co-authored-by: Taimoor Ahmed <[email protected]> (cherry picked from commit 0595e5a)
tonybusa
pushed a commit
to tonybusa/edx-platform
that referenced
this pull request
Apr 23, 2025
Co-authored-by: Taimoor Ahmed <[email protected]>
Abdul-Muqadim-Arbisoft
pushed a commit
to edly-io/edx-platform
that referenced
this pull request
Apr 25, 2025
Co-authored-by: Taimoor Ahmed <[email protected]>
ziafazal
pushed a commit
that referenced
this pull request
Apr 28, 2025
* fix: discussion xblock not compatible with forum v2 (#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <[email protected]> * fix: legacy discussion issues (#36433) Explicitly passed course_id to all views * fix: legacy forum issues (#36470) Co-authored-by: Taimoor Ahmed <[email protected]> * build: Switch off deprecated C-Hive NPM cache (#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request #35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Ali Salman <[email protected]> Co-authored-by: Kyle McCormick <[email protected]> Co-authored-by: Feanil Patel <[email protected]>
zubairshakoorarbisoft
pushed a commit
to zubairshakoorarbisoft/edx-platform
that referenced
this pull request
May 9, 2025
* fix: discussion xblock not compatible with forum v2 (openedx#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <[email protected]> * fix: legacy discussion issues (openedx#36433) Explicitly passed course_id to all views * fix: legacy forum issues (openedx#36470) Co-authored-by: Taimoor Ahmed <[email protected]> * build: Switch off deprecated C-Hive NPM cache (openedx#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Ali Salman <[email protected]> Co-authored-by: Kyle McCormick <[email protected]> Co-authored-by: Feanil Patel <[email protected]>
zubairshakoorarbisoft
pushed a commit
to zubairshakoorarbisoft/edx-platform
that referenced
this pull request
May 9, 2025
* fix: discussion xblock not compatible with forum v2 (openedx#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <[email protected]> * fix: legacy discussion issues (openedx#36433) Explicitly passed course_id to all views * fix: legacy forum issues (openedx#36470) Co-authored-by: Taimoor Ahmed <[email protected]> * build: Switch off deprecated C-Hive NPM cache (openedx#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Ali Salman <[email protected]> Co-authored-by: Kyle McCormick <[email protected]> Co-authored-by: Feanil Patel <[email protected]>
UsamaSadiq
pushed a commit
that referenced
this pull request
May 14, 2025
Co-authored-by: Taimoor Ahmed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes compatibility issues with legacy inline discussion module.
The issue was that course_id was not being passed as str which was causing the non mfe discussion page to break.
Moreover, it fixes a problematic user api call in discussions which wasn't being passed the course_id leading to failure in switching the forum backend from mongo to mysql.
Issue: #36450