fix: legacy discussion issues #36433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly passed course_id to all views
taimoor-ahmed-1
approved these changes
Mar 24, 2025
taimoor-ahmed-1
approved these changes
Mar 24, 2025
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
leoaulasneo98
pushed a commit
to aulasneo/edx-platform
that referenced
this pull request
Mar 26, 2025
Explicitly passed course_id to all views
tonybusa
pushed a commit
to tonybusa/edx-platform
that referenced
this pull request
Apr 23, 2025
Explicitly passed course_id to all views
Abdul-Muqadim-Arbisoft
pushed a commit
to edly-io/edx-platform
that referenced
this pull request
Apr 25, 2025
Explicitly passed course_id to all views
ziafazal
pushed a commit
that referenced
this pull request
Apr 28, 2025
* fix: discussion xblock not compatible with forum v2 (#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <[email protected]> * fix: legacy discussion issues (#36433) Explicitly passed course_id to all views * fix: legacy forum issues (#36470) Co-authored-by: Taimoor Ahmed <[email protected]> * build: Switch off deprecated C-Hive NPM cache (#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request #35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Ali Salman <[email protected]> Co-authored-by: Kyle McCormick <[email protected]> Co-authored-by: Feanil Patel <[email protected]>
zubairshakoorarbisoft
pushed a commit
to zubairshakoorarbisoft/edx-platform
that referenced
this pull request
May 9, 2025
* fix: discussion xblock not compatible with forum v2 (openedx#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <[email protected]> * fix: legacy discussion issues (openedx#36433) Explicitly passed course_id to all views * fix: legacy forum issues (openedx#36470) Co-authored-by: Taimoor Ahmed <[email protected]> * build: Switch off deprecated C-Hive NPM cache (openedx#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Ali Salman <[email protected]> Co-authored-by: Kyle McCormick <[email protected]> Co-authored-by: Feanil Patel <[email protected]>
zubairshakoorarbisoft
pushed a commit
to zubairshakoorarbisoft/edx-platform
that referenced
this pull request
May 9, 2025
* fix: discussion xblock not compatible with forum v2 (openedx#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <[email protected]> * fix: legacy discussion issues (openedx#36433) Explicitly passed course_id to all views * fix: legacy forum issues (openedx#36470) Co-authored-by: Taimoor Ahmed <[email protected]> * build: Switch off deprecated C-Hive NPM cache (openedx#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Ali Salman <[email protected]> Co-authored-by: Kyle McCormick <[email protected]> Co-authored-by: Feanil Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed all views where course_id was not provided to the forum v2 functions.
Supporting information
Related PR: #36315
Testing instructions
TBD
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.